Thanks to visit codestin.com
Credit goes to github.com

Skip to content

giscus not working without dark mode #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gordonwoodhull opened this issue May 7, 2025 · 0 comments · Fixed by #12702
Closed

giscus not working without dark mode #12700

gordonwoodhull opened this issue May 7, 2025 · 0 comments · Fixed by #12702
Assignees
@gordonwoodhull
Labels
backport bug Something isn't working themes Related to HTML theming or any other style related issue (like highlight-style)
Milestone
Hot-fix

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented May 7, 2025 •
edited
Loading

I just found this, because in my quarto blog, deployed as gh-pages, giscus is not loading and I see in my javascript console the following:

Uncaught ReferenceError: authorPrefersDark is not defined

Any idea?

Originally posted by @feinmann in #12611 (comment)

giscus.ejs refers to a JavaScript variable which will only exist if dark mode is enabled for the page. This code needs to be conditionally included only for dark mode.
@gordonwoodhull gordonwoodhull added bug Something isn't working backport themes Related to HTML theming or any other style related issue (like highlight-style) labels May 7, 2025
@gordonwoodhull gordonwoodhull self-assigned this May 7, 2025
@gordonwoodhull gordonwoodhull added this to the Hot-fix milestone May 7, 2025
This was referenced May 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gordonwoodhull gordonwoodhull

Labels
backport bug Something isn't working themes Related to HTML theming or any other style related issue (like highlight-style)
Projects
None yet
Milestone
Hot-fix
Development

Successfully merging a pull request may close this issue.

giscus.ejs needs to check for darkMode quarto-dev/quarto-cli
1 participant
@gordonwoodhull