Merge pull request #1 from raffaellopaletta/apm-env-tags-sf-integrations

raffaellopaletta · web-flow · commit 49d9615a193e · 2019-03-01T14:33:36.000+01:00
env tag setting via env variable in symfony integration
diff --git a/src/DDTrace/Integrations/Symfony/V3/SymfonyBundle.php b/src/DDTrace/Integrations/Symfony/V3/SymfonyBundle.php
@@ -60,6 +60,7 @@ public function boot()
         $appName = $this->getAppName();
         $symfonyRequestSpan = $scope->getSpan();
         $symfonyRequestSpan->setTag(Tags\SERVICE_NAME, $appName);
+        $symfonyRequestSpan->setTag(Tags\ENV, $this->getAppEnv());
         $symfonyRequestSpan->setTag(Tags\SPAN_TYPE, Types\WEB_SERVLET);
         $request = null;
 
@@ -223,4 +224,13 @@ private function getAppName()
             return 'symfony';
         }
     }
+
+    private function getAppEnv()
+    {
+        if ($appName = getenv('ddtrace_app_env')) {
+            return $appName;
+        } else {
+            return 'none';
+        }
+    }
 }
diff --git a/src/DDTrace/Integrations/Symfony/V4/SymfonyBundle.php b/src/DDTrace/Integrations/Symfony/V4/SymfonyBundle.php
@@ -57,6 +57,7 @@ public function boot()
         $scope = $tracer->startActiveSpan('symfony.request');
         $symfonyRequestSpan = $scope->getSpan();
         $symfonyRequestSpan->setTag(Tags\SERVICE_NAME, $this->getAppName());
+        $symfonyRequestSpan->setTag(Tags\ENV, $this->getAppEnv());
         $symfonyRequestSpan->setTag(Tags\SPAN_TYPE, Types\WEB_SERVLET);
 
         // public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQUEST, $catch = true)
@@ -141,4 +142,13 @@ private function getAppName()
             return 'symfony';
         }
     }
+
+    private function getAppEnv()
+    {
+        if ($appName = getenv('ddtrace_app_env')) {
+            return $appName;
+        } else {
+            return 'none';
+        }
+    }
 }
