Adds unhover events to pie graphs with tests

Ben Cutrell · Ben Cutrell · commit 6c42b04d0add · 2016-04-08T10:51:39.000-04:00
diff --git a/src/plots/cartesian/graph_interact.js b/src/plots/cartesian/graph_interact.js
@@ -1277,7 +1277,14 @@ function hoverChanged(gd, evt, oldhoverdata) {
 }
 
 // remove hover effects on mouse out, and emit unhover event
-function unhover(gd, evt) {
+function unhover(gd, evt, subplot) {
+    if (subplot === 'pie') {
+        gd.emit('plotly_unhover', {
+            points: [evt]
+        });
+        return;
+    }
+
     var fullLayout = gd._fullLayout;
     if(!evt) evt = {};
     if(evt.target &&
diff --git a/src/traces/pie/plot.js b/src/traces/pie/plot.js
@@ -14,6 +14,7 @@ var Fx = require('../../plots/cartesian/graph_interact');
 var Color = require('../../components/color');
 var Drawing = require('../../components/drawing');
 var svgTextUtils = require('../../lib/svg_text_utils');
+var Plotly = require('../../plotly');
 
 var helpers = require('./helpers');
 
@@ -129,7 +130,8 @@ module.exports = function plot(gd, cdpie) {
                     hasHoverData = true;
                 }
 
-                function handleMouseOut() {
+                function handleMouseOut(evt) {
+                    Plotly.Fx.unhover(gd, evt, 'pie');
                     if(hasHoverData) {
                         Fx.loneUnhover(fullLayout._hoverlayer.node());
                         hasHoverData = false;
diff --git a/test/jasmine/tests/unhover_pie_test.js b/test/jasmine/tests/unhover_pie_test.js
@@ -0,0 +1,65 @@
+var Plotly = require('@lib/index');
+var Lib = require('@src/lib');
+
+var createGraphDiv = require('../assets/create_graph_div');
+var destroyGraphDiv = require('../assets/destroy_graph_div');
+var mouseEvent = require('../assets/mouse_event');
+
+describe('pie unhovering', function() {
+    var mock = require('@mocks/pie_simple.json');
+
+    describe('event data', function() {
+        var mockCopy = Lib.extendDeep({}, mock),
+            width = mockCopy.layout.width,
+            height = mockCopy.layout.height,
+            gd;
+
+        beforeEach(function(done) {
+            gd = createGraphDiv();
+
+            Plotly.plot(gd, mockCopy.data, mockCopy.layout)
+                .then(done);
+        });
+
+        afterEach(destroyGraphDiv);
+
+        it('should contain the correct fields', function() {
+            var futureData;
+
+            gd.on('plotly_unhover', function(data) {
+                futureData = data;
+            });
+
+            var x = width / 2
+            var y = height / 2
+            mouseEvent('mouseover', x, y);
+            mouseEvent('mouseout', x, y);
+
+            expect(futureData.points.length).toEqual(1);
+            expect(Object.keys(futureData.points[0])).toEqual([
+                    'v', 'label', 'color', 'i', 'hidden',
+                    'text', 'px1', 'pxmid', 'midangle',
+                    'px0', 'largeArc', 'cxFinal', 'cyFinal'
+                ]);
+            expect(futureData.points[0].i).toEqual(3);
+        });
+
+        it('should fire when the mouse moves off the graph', function(done) {
+            var count = 0
+            futureData = [];
+
+            gd.on('plotly_unhover', function(data) {
+                count++;
+            });
+            // // mouseEvent('mouseout', 180, 140);
+            // expect(count).toEqual(3);
+
+            setTimeout(function() {
+                mouseEvent('mouseover', 180, 140);
+                mouseEvent('mouseout', 180, 140);
+                expect(count).toEqual(1);
+                done();
+            }, 100);
+        });
+    });
+});
