webpacker:install does not require webpacker.yml

justin808 · justin808 · commit ce7cdd707f79 · 2021-11-12T13:42:17.000-10:00
If you run ./bin/rails webpacker:install on a rails app with no
config/webpacker.yml, we get a crash with this error:

&gt; Webpacker configuration file not found webpacker-v6/config/webpacker.yml.

&gt; Please run rails webpacker:install Error: No such file or directory @
rb_check_realpath_internal - webpacker-v6/config/webpacker.yml

With this fix, allow installer to run.

Problem solved with a global to indicate installing so that default
configuration is used rather than crashing because the yet to be
installed config/webpacker.yml is not yet installed.
diff --git a/lib/tasks/webpacker/install.rake b/lib/tasks/webpacker/install.rake
@@ -4,6 +4,7 @@ bin_path = ENV["BUNDLE_BIN"] || Rails.root.join("bin")
 namespace :webpacker do
   desc "Install Webpacker in this application"
   task install: [:check_node, :check_yarn] do |task|
+    @@webpacker_installing = true
     prefix = task.name.split(/#|webpacker:install/).first
 
     if Rails::VERSION::MAJOR >= 5
diff --git a/lib/webpacker/configuration.rb b/lib/webpacker/configuration.rb
@@ -80,10 +80,13 @@ def load
       end
       config[env].deep_symbolize_keys
     rescue Errno::ENOENT => e
-      raise "Webpacker configuration file not found #{config_path}. " \
-            "Please run rails webpacker:install " \
-            "Error: #{e.message}"
-
+      if @@webpacker_installing
+        {}
+      else
+        raise "Webpacker configuration file not found #{config_path}. " \
+              "Please run rails webpacker:install " \
+              "Error: #{e.message}"
+      end
     rescue Psych::SyntaxError => e
       raise "YAML syntax error occurred while parsing #{config_path}. " \
             "Please note that YAML must be consistently indented using spaces. Tabs are not allowed. " \
