add a some potential TODOs

etpinard · etpinard · commit 48df69940f9f · 2018-12-05T16:36:57.000-05:00
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -157,7 +157,7 @@ var getDataConversions = axes.getDataConversions = function(gd, trace, target, t
                 ax.d2c(targetArray[i]);
             }
         }
-        // TODO?
+        // TODO what to do for transforms?
     } else {
         ax = axes.getFromTrace(gd, trace, d2cTarget);
     }
diff --git a/src/traces/bar/cross_trace_calc.js b/src/traces/bar/cross_trace_calc.js
@@ -126,6 +126,8 @@ function initBase(gd, pa, sa, calcTraces) {
         // time. But included here for completeness.
         var scalendar = trace.orientation === 'h' ? trace.xcalendar : trace.ycalendar;
 
+        // TODO skip for multicategory size axis?
+
         if(isArrayOrTypedArray(base)) {
             for(j = 0; j < Math.min(base.length, cd.length); j++) {
                 b = sa.d2c(base[j], 0, scalendar);
diff --git a/src/traces/box/calc.js b/src/traces/box/calc.js
@@ -178,6 +178,7 @@ function getPos(trace, posLetter, posAxis, val, num) {
         pos0 = num;
     }
 
+    // TODO what to do on multicategory posAxis?
     var pos0c = posAxis.d2c(pos0, 0, trace[posLetter + 'calendar']);
     return val.map(function() { return pos0c; });
 }
diff --git a/src/traces/heatmap/convert_column_xyz.js b/src/traces/heatmap/convert_column_xyz.js
@@ -23,6 +23,7 @@ module.exports = function convertColumnData(trace, ax1, ax2, var1Name, var2Name,
 
     var i, j, arrayVar, newArray, arrayVarName;
 
+    // TODO use makeCalcdata to make this work for multicategory?
     for(i = 0; i < colLen; i++) {
         col1[i] = ax1.d2c(col1[i], 0, col1Calendar);
         col2[i] = ax2.d2c(col2[i], 0, col2Calendar);
diff --git a/src/traces/heatmap/make_bound_array.js b/src/traces/heatmap/make_bound_array.js
@@ -71,6 +71,7 @@ module.exports = function makeBoundArray(trace, arrayIn, v0In, dvIn, numbricks,
         else if(isArrayOrTypedArray(arrayIn) && arrayIn.length === 1) v0 = arrayIn[0];
         else if(v0In === undefined) v0 = 0;
         else v0 = ax.d2c(v0In, 0, calendar);
+        // TODO what to do for multicategory?
 
         for(i = (isContour || isGL2D) ? 0 : -0.5; i < numbricks; i++) {
             arrayOut.push(v0 + dv * i);
diff --git a/src/traces/violin/calc.js b/src/traces/violin/calc.js
@@ -123,6 +123,7 @@ function calcSpan(trace, cdi, valAxis, bandwidth) {
 
     function calcSpanItem(index) {
         var s = spanIn[index];
+        // TODO skip on multicategory val axis?
         var sc = valAxis.d2c(s, 0, trace[cdi.valLetter + 'calendar']);
         return sc === BADNUM ? spanLoose[index] : sc;
     }

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ var getDataConversions = axes.getDataConversions = function(gd, trace, target, t`
`157`	`157`	`ax.d2c(targetArray[i]);`
`158`	`158`	`}`
`159`	`159`	`}`
`160`		`- // TODO?`
	`160`	`+ // TODO what to do for transforms?`
`161`	`161`	`} else {`
`162`	`162`	`ax = axes.getFromTrace(gd, trace, d2cTarget);`
`163`	`163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,7 @@ function getPos(trace, posLetter, posAxis, val, num) {`
`178`	`178`	`pos0 = num;`
`179`	`179`	`}`
`180`	`180`
	`181`	`+ // TODO what to do on multicategory posAxis?`
`181`	`182`	`var pos0c = posAxis.d2c(pos0, 0, trace[posLetter + 'calendar']);`
`182`	`183`	`return val.map(function() { return pos0c; });`
`183`	`184`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ function calcSpan(trace, cdi, valAxis, bandwidth) {`
`123`	`123`
`124`	`124`	`function calcSpanItem(index) {`
`125`	`125`	`var s = spanIn[index];`
	`126`	`+ // TODO skip on multicategory val axis?`
`126`	`127`	`var sc = valAxis.d2c(s, 0, trace[cdi.valLetter + 'calendar']);`
`127`	`128`	`return sc === BADNUM ? spanLoose[index] : sc;`
`128`	`129`	`}`