chore(deps): support strum 0.28 (#224)

joshka · web-flow · commit fe402493e108 · 2026-04-04T15:47:15.000-07:00
## Summary This PR fixes the `strum 0.28` dependency bump proposed in [#210](#210) and adds explicit `cargo check --all-targets --all-features --workspace` coverage so example-target compile failures are caught directly in CI instead of being missed by the existing workspace check. ## Root Cause The failure came from the `tui-bar-graph` example, where clap derives a parser for `BarStyle`. `BarStyle` still derives `FromStr`, and this was not caused by the `#[strum(default)]` behavior change from [strum PR #476](Peternator7/strum#476). The actual issue was dependency resolution plus feature unification. Before the bump, `tui-bar-graph` and `ratatui-core` both used `strum 0.27`, so Cargo unified them and `ratatui-core`'s `strum/std` activation effectively carried `std` into the `strum` instance used by `tui-bar-graph`. After [#210](#210), `tui-bar-graph` used `strum 0.28` while `ratatui-core` still used `strum 0.27`, so the graph split into separate `strum` packages. At that point, `tui-bar-graph`'s own `strum 0.28` was built with `default-features = false`, which meant `strum::ParseError` no longer implemented `std::error::Error` in that context. That was enough to break clap's inferred parser for `BarStyle`. ## Code Changes `tui-bar-graph` now declares an explicit `std` feature and uses it to enable `strum/std`. `std` remains enabled by default, so the crate's normal ergonomics do not change. The interactive example is marked with `required-features = ["std"]` so its compile requirements are explicit instead of depending on accidental transitive feature behavior. `colorgrad` now uses `default-features = false`. ## Why Only `strum/std` `strum/std` matters here because it affects trait-based downstream integration on a public enum type. `BarStyle` derives traits whose interaction with clap depends on the trait set of `strum::ParseError`. `colorgrad/std` does not play the same role in this crate today, so the `std` feature does not forward `colorgrad/std`. ## Docs The crate now uses `document-features` so the feature contract is rendered in generated docs and on docs.rs. ## CI The issue exposed by [#210](#210) was a normal compile failure in a non-lib target. The workspace already ran `cargo check --all-features --workspace`, but that does not compile examples and other non-lib targets. `cargo check --all-targets --all-features --workspace` reproduces the failure directly. This PR adds explicit all-targets compile coverage so example-target breakage is caught as a normal build/check failure. ## Verification ```shell cargo check --all-targets --all-features --workspace cargo clippy --all-targets --all-features --workspace -- -D warnings cargo check -p tui-bar-graph --lib --no-default-features cargo doc -p tui-bar-graph --all-features cargo rdme --check --manifest-path tui-bar-graph/Cargo.toml ``` ## Follow-up A broader `no_std` audit of the other widget crates was done during this work and recorded separately on [#102](#102).
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -38,6 +38,19 @@ jobs:
       - name: Run clippy
         run: cargo clippy --all-targets --all-features --workspace -- -D warnings
 
+  targets:
+    name: Check Targets
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+      - name: Cache Rust build artifacts
+        uses: Swatinem/rust-cache@v2
+      - name: Check all workspace targets
+        run: cargo check --all-targets --all-features --workspace
+
   docs:
     name: Docs
     runs-on: ubuntu-latest
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -31,7 +31,7 @@ ratatui-core = { version = "0.1" }
 ratatui-macros = "0.7"
 ratatui-widgets = { version = "0.3" }
 rstest = "0.26"
-strum = { version = "0.27", default-features = false, features = ["derive"] }
+strum = { version = "0.28", default-features = false, features = ["derive"] }
 tokio = { version = "1" }
 
 [lints.rust]
diff --git a/tui-bar-graph/Cargo.toml b/tui-bar-graph/Cargo.toml
@@ -11,8 +11,18 @@ rust-version.workspace = true
 categories.workspace = true
 keywords.workspace = true
 
+[package.metadata.docs.rs]
+all-features = true
+rustdoc-args = ["--cfg", "docsrs"]
+
+[features]
+default = ["std"]
+## enables std
+std = ["strum/std"]
+
 [dependencies]
-colorgrad = { version = "0.8", features = ["preset"] }
+colorgrad = { version = "0.8", default-features = false, features = ["preset"] }
+document-features.workspace = true
 ratatui-core.workspace = true
 strum.workspace = true
 
@@ -22,3 +32,7 @@ color-eyre.workspace = true
 crossterm.workspace = true
 rand.workspace = true
 ratatui = { workspace = true, default-features = true }
+
+[[example]]
+name = "tui-bar-graph"
+required-features = ["std"]
diff --git a/tui-bar-graph/src/lib.rs b/tui-bar-graph/src/lib.rs
@@ -81,6 +81,8 @@
 //!
 //! [Joshka]: https://github.com/joshka
 //! [tui-widgets]: https://crates.io/crates/tui-widgets
+#![cfg_attr(docsrs, doc = "\n# Feature flags\n")]
+#![cfg_attr(docsrs, doc = document_features::document_features!())]
 
 use colorgrad::Gradient;
 use ratatui_core::buffer::Buffer;
