Optimze ProcessStartInfo arguments handling #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the pull request. I was working on it, but didn't know about the ArgumentList. Your solution is much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZipExtractor project
FormMain.csis using APIEnvironment.GetCommandLineArgs()to get arguments.According to MSDN https://learn.microsoft.com/en-us/dotnet/api/system.environment.getcommandlineargs. this API is very strictly on handling of backslashes and double quotation marks.
If our app is under some root directory such as d:\
We are supposed to get args
--output "d:\"in ZipExtractor, but it actrully geting--output d:", obviously this is not a valid path #608 .This is a hidden danger of concatenating arguments to a string.
ProcessStartInfoclass has a propertyArgumentList, which can handle argument separation automaticlly. we will no more struggling with spaces, backslashes, and quotation marks.