[core] Remove RAY_CHECK from GetAndPinArgsForExecution #56470
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like there are scenarios where getting a bad status from calls to this function is fairly legitamate (for example, during shutdown). A better course of action would be propogate the status back up. TaskReceiver now seems to handle bad status codes well and doesn't crash the node. So downgrading the RAY_CHECK seems a good fix in any case Signed-off-by: zac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Today if a bad status is reported at any step in GetAndPinArgsForExecution, we hit the RAY_CHECK and crash the process.
However, it seems like there are scenarios where getting a bad status from calls to this function is fairly legitamate (for example, during shutdown, raylet will return bad status codes like broken pipe status). A better course of action would be propogate the status back up and have the caller decide what to do next in the context of the ExecuteTask call. TaskReceiver now seems to handle bad status codes well and doesn't crash the node. So downgrading the RAY_CHECK seems a good fix in any case.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.