span: implement update_name method (open-telemetry#112)

mauriciovasquezbernal · reyang · commit abe00f7ae912 · 2019-08-29T08:54:42.000-07:00
diff --git a/opentelemetry-api/src/opentelemetry/trace/__init__.py b/opentelemetry-api/src/opentelemetry/trace/__init__.py
@@ -132,6 +132,16 @@ def add_link(self: 'Span',
         `SpanContext` passed as argument.
         """
 
+    def update_name(self, name: str) -> None:
+        """Updates the `Span` name.
+
+        This will override the name provided via :func:`Tracer.create_span`
+        or :func:`Tracer.start_span`.
+
+        Upon this update, any sampling behavior based on Span name will depend
+        on the implementation.
+        """
+
 
 class TraceOptions(int):
     """A bitmask that represents options specific to the trace.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -261,6 +261,9 @@ def end(self):
         if self.end_time is None:
             self.end_time = util.time_ns()
 
+    def update_name(self, name: str) -> None:
+        self.name = name
+
 
 def generate_span_id():
     """Get a new random span ID.
diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -145,6 +145,9 @@ def test_span_members(self):
             root.add_link(other_context1)
             root.add_link(other_context2, {'name': 'neighbor'})
 
+            root.update_name('toor')
+            self.assertEqual(root.name, 'toor')
+
             # The public API does not expose getters.
             # Checks by accessing the span members directly
 
