-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update BasicUsage.md #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update BasicUsage.md #1632
Conversation
I'm not sure about the wording here regarding not seeing video. We receive many issues like that, but the problem is different usually server side, and this might point people in the wrong direction. Thoughts? @davidliu @8BallBomBom |
Well, it's worth adding a line of styles to check if it won't fix things for people before troubleshooting servers :) |
Definitely not something you'd think would be needed in the basic usage docs 🤔 Honestly this has surprised me, not sure how to respond exactly 🫨 That being said, another thought, maybe a better solution would be to do a default style for the component. |
I like this. |
@aszmyd Do you want to make the discussed changes? |
I'm happy to try it. Need to dive a bit deeper into how the components are made here but that would be a good learning. |
I wanted to say that I was tripped up by this last week. This PR was helpful to me to understand the intent for the |
Definitely could be more clear. |
Docs update (#1631)