Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

aszmyd
Copy link

@aszmyd aszmyd commented Oct 2, 2024

Docs update (#1631)

@saghul
Copy link
Member

saghul commented Oct 2, 2024

I'm not sure about the wording here regarding not seeing video.

We receive many issues like that, but the problem is different usually server side, and this might point people in the wrong direction.

Thoughts? @davidliu @8BallBomBom

@aszmyd
Copy link
Author

aszmyd commented Oct 2, 2024

Well, it's worth adding a line of styles to check if it won't fix things for people before troubleshooting servers :)
I'm fine with changing the wording to whatever you prefer.

@8BallBomBom
Copy link
Member

8BallBomBom commented Oct 2, 2024

Definitely not something you'd think would be needed in the basic usage docs 🤔
By default you would style components to position and size them as needed for your project.
Typically that is a known basic requirement for when you build anything you want to render on screen.

Honestly this has surprised me, not sure how to respond exactly 🫨

That being said, another thought, maybe a better solution would be to do a default style for the component.
Which could then also include some documentation stating the component is set to fit the allowed space by default.

@saghul
Copy link
Member

saghul commented Oct 3, 2024

That being said, another thought, maybe a better solution would be to do a default style for the component.
Which could then also include some documentation stating the component is set to fit the allowed space by default.

I like this.

@8BallBomBom
Copy link
Member

@aszmyd Do you want to make the discussed changes?
Otherwise, no worries, will open a pr shortly 😄

@aszmyd
Copy link
Author

aszmyd commented Oct 7, 2024

@aszmyd Do you want to make the discussed changes? Otherwise, no worries, will open a pr shortly 😄

I'm happy to try it. Need to dive a bit deeper into how the components are made here but that would be a good learning.

@stale stale bot added the wontfix There are no plans to work on this label Dec 7, 2024
@react-native-webrtc react-native-webrtc deleted a comment from stale bot Dec 7, 2024
@stale stale bot removed the wontfix There are no plans to work on this label Dec 7, 2024
@stale stale bot added the wontfix There are no plans to work on this label Feb 6, 2025
@8BallBomBom 8BallBomBom marked this pull request as draft February 6, 2025 13:35
@stale stale bot removed the wontfix There are no plans to work on this label Feb 6, 2025
@react-native-webrtc react-native-webrtc deleted a comment from stale bot Feb 6, 2025
@Mrjaco12
Copy link

Mrjaco12 commented Apr 7, 2025

I wanted to say that I was tripped up by this last week. This PR was helpful to me to understand the intent for the RTCView component. I think maybe the objectFit prop implies some level of default styling that doesn't exist. I'd be happy to help out if I can.

@8BallBomBom
Copy link
Member

Definitely could be more clear.
Will pick this up when i have some free time.
A lot of good points to consider 🤔

@stale stale bot added the wontfix There are no plans to work on this label Jun 6, 2025
@react-native-webrtc react-native-webrtc deleted a comment from stale bot Jun 9, 2025
@stale stale bot removed the wontfix There are no plans to work on this label Jun 9, 2025
@stale stale bot added the wontfix There are no plans to work on this label Aug 8, 2025
@react-native-webrtc react-native-webrtc deleted a comment from stale bot Aug 11, 2025
@stale stale bot removed the wontfix There are no plans to work on this label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants