From f2b5c17090976129115edc651a8b890eca9d1955 Mon Sep 17 00:00:00 2001 From: Chris Pulman Date: Fri, 17 May 2024 01:16:11 +0100 Subject: [PATCH 1/2] Housekeeping Retire Net 7 --- .editorconfig | 7 +++- src/Directory.Packages.props | 2 +- src/Directory.build.props | 17 +++----- src/Directory.build.targets | 41 ++----------------- .../ReactiveUI.Blazor.csproj | 2 - src/ReactiveUI.Maui/ReactiveUI.Maui.csproj | 10 ++--- src/ReactiveUI.Tests/ReactiveUI.Tests.csproj | 4 +- src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj | 2 +- src/ReactiveUI/ReactiveUI.csproj | 6 ++- version.json | 2 +- 10 files changed, 28 insertions(+), 65 deletions(-) diff --git a/.editorconfig b/.editorconfig index f1d3d943d3..be457ccc61 100644 --- a/.editorconfig +++ b/.editorconfig @@ -296,7 +296,7 @@ dotnet_diagnostic.SA1006.severity = error dotnet_diagnostic.SA1007.severity = error dotnet_diagnostic.SA1008.severity = error dotnet_diagnostic.SA1009.severity = error -dotnet_diagnostic.SA1010.severity = suggestion +dotnet_diagnostic.SA1010.severity = none dotnet_diagnostic.SA1011.severity = error dotnet_diagnostic.SA1012.severity = error dotnet_diagnostic.SA1013.severity = error @@ -469,10 +469,11 @@ dotnet_diagnostic.CA1825.severity=error dotnet_diagnostic.CA1812.severity=error dotnet_diagnostic.CA1805.severity=error dotnet_diagnostic.RCS1197.severity=error -dotnet_diagnostic.RCS1198.severity=suggestion +dotnet_diagnostic.RCS1198.severity=none dotnet_diagnostic.RCS1231.severity=suggestion dotnet_diagnostic.RCS1235.severity=error dotnet_diagnostic.RCS1242.severity=error +dotnet_diagnostic.RCS1256.severity=none dotnet_diagnostic.CA2016.severity=warning dotnet_diagnostic.CA2014.severity=error dotnet_diagnostic.RCS1010.severity=error @@ -489,6 +490,8 @@ dotnet_diagnostic.RCS1105.severity=error dotnet_diagnostic.RCS1112.severity=error dotnet_diagnostic.RCS1128.severity=error dotnet_diagnostic.RCS1143.severity=error +dotnet_diagnostic.RCS1158.severity=none +dotnet_diagnostic.RCS1163.severity=none dotnet_diagnostic.RCS1171.severity=error dotnet_diagnostic.RCS1173.severity=error dotnet_diagnostic.RCS1176.severity=error diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 61e2440c18..d514bca311 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -5,7 +5,7 @@ 6.8.0 - 15.0.1 + 15.1.1 28.0.0.3 2.6.6 23.2.0 diff --git a/src/Directory.build.props b/src/Directory.build.props index 5c0ab38a4f..f165b79ab4 100644 --- a/src/Directory.build.props +++ b/src/Directory.build.props @@ -12,12 +12,12 @@ https://reactiveui.net A MVVM framework that integrates with the Reactive Extensions for .NET to create elegant, testable User Interfaces that run on any mobile or desktop platform. Supports Xamarin.iOS, Xamarin.Android, Xamarin.Mac, Xamarin Forms, Xamarin.TVOS, Tizen, WPF, Windows Forms, Universal Windows Platform (UWP) and the Uno Platform. $(DefaultPackageDescription) - xanaisbettsx;ghuntley + anaisbetts;ghuntley mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;frp;xamarin;android;ios;mac;forms;monodroid;monotouch;xamarin.android;xamarin.ios;xamarin.forms;xamarin.mac;xamarin.tvos;wpf;net;netstandard;net462;winui;maui;tizen;unoplatform https://github.com/reactiveui/ReactiveUI/releases https://github.com/reactiveui/reactiveui git - $(NoWarn);SA1010;RCS1198;RCS1158;RCS1163;RCS1256;IDE0060;IDE1006;VSSpell001 + $(NoWarn);IDE0060;IDE1006;VSSpell001 true @@ -32,16 +32,9 @@ true true true - net462;net472;net6.0-windows10.0.17763.0;net7.0-windows10.0.17763.0;net8.0-windows10.0.17763.0;net6.0-windows10.0.19041.0;net7.0-windows10.0.19041.0;net8.0-windows10.0.19041.0 - net7.0-android;net7.0-ios;net7.0-tvos;net7.0-macos;net7.0-maccatalyst;net8.0-android;net8.0-ios;net8.0-tvos;net8.0-macos;net8.0-maccatalyst - netstandard2.0;net6.0;net7.0;net8.0 - - - - - portable + net462;net472;net6.0-windows10.0.17763.0;net8.0-windows10.0.17763.0;net6.0-windows10.0.19041.0;net8.0-windows10.0.19041.0 + net8.0-android;net8.0-ios;net8.0-tvos;net8.0-macos;net8.0-maccatalyst + netstandard2.0;net6.0;net8.0 true diff --git a/src/Directory.build.targets b/src/Directory.build.targets index 33ce2ceff2..fd3a50d51d 100644 --- a/src/Directory.build.targets +++ b/src/Directory.build.targets @@ -13,49 +13,16 @@ $(DefineConstants);NET_461;XAML - + $(DefineConstants);MONO;UIKIT;COCOA;IOS - - $(DefineConstants);MONO;UIKIT;COCOA;IOS - - - $(DefineConstants);MONO;UIKIT;COCOA;IOS - - - $(DefineConstants);MONO;UIKIT;COCOA;IOS - - - $(DefineConstants);MONO;UIKIT;COCOA;IOS - - - $(DefineConstants);MONO;UIKIT;COCOA;IOS - - - $(DefineConstants);MONO;COCOA;MAC - - - $(DefineConstants);MONO;COCOA;MAC - - + $(DefineConstants);MONO;COCOA;MAC - + $(DefineConstants);MONO;UIKIT;COCOA;TVOS - - $(DefineConstants);MONO;UIKIT;COCOA;TVOS - - - $(DefineConstants);MONO;UIKIT;COCOA;TVOS - - - $(DefineConstants);MONO;ANDROID - - - $(DefineConstants);MONO;ANDROID - - + $(DefineConstants);MONO;ANDROID diff --git a/src/ReactiveUI.Blazor/ReactiveUI.Blazor.csproj b/src/ReactiveUI.Blazor/ReactiveUI.Blazor.csproj index ae273d2bdf..fa5fbf69d5 100644 --- a/src/ReactiveUI.Blazor/ReactiveUI.Blazor.csproj +++ b/src/ReactiveUI.Blazor/ReactiveUI.Blazor.csproj @@ -7,8 +7,6 @@ - - diff --git a/src/ReactiveUI.Maui/ReactiveUI.Maui.csproj b/src/ReactiveUI.Maui/ReactiveUI.Maui.csproj index 5034a22788..2c448693b7 100644 --- a/src/ReactiveUI.Maui/ReactiveUI.Maui.csproj +++ b/src/ReactiveUI.Maui/ReactiveUI.Maui.csproj @@ -1,7 +1,7 @@  - net7.0;net8.0 - $(TargetFrameworks);net7.0-windows10.0.19041.0;net8.0-windows10.0.19041.0 + net8.0 + $(TargetFrameworks);net8.0-windows10.0.19041.0 Contains the ReactiveUI platform specific extensions for Microsoft Maui mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;frp;maui;android;ios;mac;windows;net true @@ -9,8 +9,8 @@ 11.0 13.1 21.0 - 10.0.17763.0 - 10.0.17763.0 + 10.0.19041.0 + 10.0.19041.0 6.5 @@ -19,7 +19,7 @@ - + diff --git a/src/ReactiveUI.Tests/ReactiveUI.Tests.csproj b/src/ReactiveUI.Tests/ReactiveUI.Tests.csproj index 58b2ddac27..dcb04a9dc7 100644 --- a/src/ReactiveUI.Tests/ReactiveUI.Tests.csproj +++ b/src/ReactiveUI.Tests/ReactiveUI.Tests.csproj @@ -1,7 +1,7 @@  - net6.0;net7.0;net8.0 - net472;net6.0-windows10.0.17763.0;net7.0-windows10.0.17763.0;net8.0-windows10.0.17763.0 + net6.0;net8.0 + net472;net6.0-windows10.0.17763.0;net8.0-windows10.0.17763.0 $(NoWarn);CS1591 diff --git a/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj b/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj index 00e9661e9a..0094b7c68e 100644 --- a/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj +++ b/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj @@ -1,6 +1,6 @@  - net6.0-windows10.0.19041.0;net7.0-windows10.0.19041.0;net8.0-windows10.0.19041.0 + net6.0-windows10.0.19041.0;net8.0-windows10.0.19041.0 10.0.19041.0 Contains the ReactiveUI platform specific extensions for WinUI Desktop ReactiveUI.WinUI.Desktop diff --git a/src/ReactiveUI/ReactiveUI.csproj b/src/ReactiveUI/ReactiveUI.csproj index 5f890344d3..a551b1b80c 100644 --- a/src/ReactiveUI/ReactiveUI.csproj +++ b/src/ReactiveUI/ReactiveUI.csproj @@ -22,7 +22,7 @@ - + @@ -56,10 +56,12 @@ + + + - diff --git a/version.json b/version.json index 2651f23ccf..1099fbe480 100644 --- a/version.json +++ b/version.json @@ -1,6 +1,6 @@ { "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", - "version": "20.0", + "version": "20.1", "publicReleaseRefSpec": [ "^refs/heads/master$", // we release out of master "^refs/heads/main$", From 6960cff055b8d71bd9189032b55fd9f47830d916 Mon Sep 17 00:00:00 2001 From: Chris Pulman Date: Sat, 18 May 2024 09:57:58 +0100 Subject: [PATCH 2/2] Reassert changes to ReactiveUI after merge conflict --- src/Directory.Packages.props | 35 ++++++-------------------------- src/ReactiveUI/ReactiveUI.csproj | 8 +++++++- 2 files changed, 13 insertions(+), 30 deletions(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 2d6293b2e3..2e9dbdc3e8 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -4,19 +4,12 @@ true - 6.8.0 15.1.1 - 28.0.0.3 - 2.8.0 - 24.2.0 - - - @@ -40,22 +33,9 @@ - - - - - - - - - - - - - - - - + + + @@ -65,17 +45,14 @@ - + - - - - + - + diff --git a/src/ReactiveUI/ReactiveUI.csproj b/src/ReactiveUI/ReactiveUI.csproj index fb21aa1699..6db3b8e51a 100644 --- a/src/ReactiveUI/ReactiveUI.csproj +++ b/src/ReactiveUI/ReactiveUI.csproj @@ -25,6 +25,11 @@ + + + + + @@ -47,8 +52,9 @@ - + +