-
Notifications
You must be signed in to change notification settings - Fork 926
Server side rendered components require server restart to take effect #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@WonSong - If you attach a debugger, do you see messages like this when you change the files?
@dustinsoftware Do you have any ideas on this? We do configure JSPool to recycle the pool on change: React.NET/src/React.Core/JavaScriptEngineFactory.cs Lines 93 to 94 in c90a4a6
And then JSPool uses a https://github.com/Daniel15/JSPool/blob/master/src/JSPool/FileWatcher.cs#L90-L102 Perhaps we're not passing the file names correctly, or passing the wrong path, or something like that. |
I was able to repro this issue with webpack 4. Try downgrading to webpack 3 and see if you're still having problems. I'm still investigating but want to rule out changes within webpack itself. |
The webpack 4 issue I thought I was encountering was a red herring, webpack 4 changed the default destination to |
On Windows |
I created a sample app, but seeing the same issue on Mac. Here's the repo: https://github.com/WonSong/ReactDotNetTypeScriptWebpackDemo |
Thanks @WonSong. I'll look at this in the next few days. |
I have wasted a lot of time struggling with this. Is there an ETA? |
Haven’t had time to look at this one yet. Details about your environment
would be helpful
Can you paste your packages.config in this issue? What version of asp.net
and .net framework are you on? 32 bit or 64 bit process?
…On Fri, Jul 20, 2018 at 12:52, Slava Knyazev ***@***.***> wrote:
I have wasted a lot of time struggling with this. Is there an ETA?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFgGlxDMJj3idtx7Rarr0z-GNNqqDks5uIjT8gaJpZM4Uub8F>
.
|
I no longer have a project using it. The general buginess and unreliability of it made me switch away. |
Glad you found another solution that fits your needs.
…On Fri, Jul 20, 2018 at 14:08, Slava Knyazev ***@***.***> wrote:
I no longer have a project using it. The general buginess and
unreliability of it made me switch away.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFpPtir7llBnHBe0M7XidPYHGFeY3ks5uIkbggaJpZM4Uub8F>
.
|
Sorry, that response may have come across as terse. I intend to debug this problem but can’t do so without detailed information about the environment this library runs in, since the bug hasn’t occurred when I have attempted to repro it. |
i still have this issue in ASP.NET Core MVC 2.1.301 both on 64bit latest MacoOs and 64bit windows 10. Still using same template as the one I provided above. |
Ok, so here's what I did to try and repro the issue (no luck). Please let me know if I am missing something. .NET Core 2.1 on OS X.
|
Interestingly, once I disabled the re-use of the rendering engine, it ceased to be an issue. Could it be that a renderer is persisting through the updates? |
Having the same issue here, turning off re-use fixed it for me too (I'm running version 3.2 on aspnet core 2.1). I've temporarily turned off re-use of the rendering engine when running locally and I would recommend anyone else to do the same as a workaround until this is fixed. Let me know if you need anymore information to identify the problem. |
Thanks that is very helpful. I’ll take a closer look. This may be a JSPool
specific issue, could you tell me what version is getting used? It is a
downstream package also you may need to look at the project lock file.
…On Fri, Aug 10, 2018 at 07:38, LinusCenterstrom ***@***.***> wrote:
Having the same issue here, turning off re-use fixed it for me too (I'm
running version 3.2 on aspnet core 2.1).
Been running it in a Mvc 4 app for a long time without seeing this issue
(exact same configuration and bundle), so it seems to be core-specific.
I've temporarily turned off re-use of the rendering engine when running
locally and I would recommend anyone else to do the same as a workaround
until this is fixed.
Let me know if you need anymore information to identify the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFqDTE6chyj7xUrsPJxUqzfLwYkaCks5uPZrWgaJpZM4Uub8F>
.
|
Ok I've finally nailed down a repro. Digging further. |
* Fix JS engine reloading in .NET Core Fixes #554 * Check environment before rewriting path * Use Path.GetFullPath
* Fix JS engine reloading in .NET Core Fixes #554 * Check environment before rewriting path * Use Path.GetFullPath
Please update to 3.4.1 and let me know if the issue is resolved. @WonSong @knyzorg @LinusCenterstrom @benjamn |
Using ASP.NET Core 2.1
Webpack 4
Typescript 2.9
The text was updated successfully, but these errors were encountered: