fix: add new option for escaping brackets in curl snippets #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where because we pass
escapeQueryStrings: false
to HTTPSnippet and don't escape query strings (instead relying on OAS style configurations), query strings in cURL snippets like[["$attributed_flow","=","FLOW_ID"]]
wouldn't be escaped if the OAS doesn't use styles, resulting in a cURL snippet that couldn't actually be run.This fixes this problem by adding a new option to the cURL target called
escapeBrackets
that when present will manually escape[
and]
in thefullUrl
data that it uses to chuck into the--url
argument.Resolves CX-347