chore: use defer instead of t.Cleanup for chdir (coder#6887)

kylecarbs · web-flow · commit 1f600fc526f6 · 2023-03-30T09:48:03.000-05:00
This _might_ resolve the races in `TestTemplatePush`.
diff --git a/cli/templatepush_test.go b/cli/templatepush_test.go
@@ -178,10 +178,7 @@ func TestTemplatePush(t *testing.T) {
 		require.NoError(t, err)
 
 		os.Chdir(source)
-
-		t.Cleanup(func() {
-			os.Chdir(oldDir)
-		})
+		defer os.Chdir(oldDir)
 
 		// Don't pass the name of the template, it should use the
 		// directory of the source.
