fix: Include 'CODER' env var prefix on group mappings (coder#7015)

Emyrk · web-flow · commit a361673ad8c1 · 2023-04-05T17:47:40.000Z
* fix: Include 'CODER' env var prefix on group mappings
* Unit test to force CODER prefix
diff --git a/codersdk/deployment_test.go b/codersdk/deployment_test.go
@@ -1,6 +1,7 @@
 package codersdk_test
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -101,6 +102,12 @@ func TestDeploymentValues_HighlyConfigurable(t *testing.T) {
 			t.Errorf("Option %q is excluded but has an env name", opt.Name)
 		}
 
+		// Also check all env vars are prefixed with CODER_
+		const prefix = "CODER_"
+		if opt.Env != "" && !strings.HasPrefix(opt.Env, prefix) {
+			t.Errorf("Option %q has an env name (%q) that is not prefixed with %s", opt.Name, opt.Env, prefix)
+		}
+
 		delete(excludes, opt.Name)
 	}
 
