[php 8.5] Split of nested functions calls to pipe operator in a new standalone rule (#7603)

TomasVotruba · samsonasik · web-flow · commit 8376d26987ca · 2025-10-29T20:46:56.000+07:00
* split fixtures

* [php 8.5] Split of nested functions calls to pipe operator in a new standalone rule

* implemented

* implemented

---------

Co-authored-by: Abdul Malik Ikhsan &lt;samsonasik@gmail.com&gt;
diff --git a/phpstan.neon b/phpstan.neon
@@ -217,12 +217,10 @@ parameters:
 
         # optional as changes behavior, should be used explicitly outside PHP upgrade
         - '#Register "Rector\\Php73\\Rector\\FuncCall\\JsonThrowOnErrorRector" service to "php73\.php" config set#'
-
         - '#Register "Rector\\Php81\\Rector\\ClassMethod\\NewInInitializerRector" service to "php81\.php" config set#'
-
         - '#Register "Rector\\Php80\\Rector\\NotIdentical\\MbStrContainsRector" service to "php80\.php" config set#'
-
         - '#Register "Rector\\Php85\\Rector\\StmtsAwareInterface\\SequentialAssignmentsToPipeOperatorRector" service to "php85\.php" config set#'
+        - '#Register "Rector\\Php85\\Rector\\Expression\\NestedFuncCallsToPipeOperatorRector" service to "php85\.php" config set#'
 
         # closure detailed
         - '#Method Rector\\Config\\RectorConfig\:\:singleton\(\) has parameter \$concrete with no signature specified for Closure#'
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_filter.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_filter.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayFilter
+{
+    public function filter(array $data)
+    {
+        return array_filter($data, 'intval');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayFilter
+{
+    public function filter(array $data)
+    {
+        return array_filter($data, intval(...));
+    }
+}
+
+?>
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_function_named_argument.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_function_named_argument.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayFunctionNamedArgument
+{
+    public function map(array $data)
+    {
+        return array_map(callback: 'strtolower', array: $data);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayFunctionNamedArgument
+{
+    public function map(array $data)
+    {
+        return array_map(callback: strtolower(...), array: $data);
+    }
+}
+
+?>
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_walk.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/array_walk.php.inc
@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayWalk
+{
+    public function walkWithArgument(array $data, mixed $additionalArgument)
+    {
+        array_walk($data, 'serialize', $additionalArgument);
+
+        return $data;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class ArrayWalk
+{
+    public function walkWithArgument(array $data, mixed $additionalArgument)
+    {
+        array_walk($data, serialize(...), $additionalArgument);
+
+        return $data;
+    }
+}
+
+?>
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/nested_array_call.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/nested_array_call.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class NestedArrayCall
+{
+    public function nestedMap(array $data)
+    {
+        return array_map('strtolower', array: array_map('trim', $data));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class NestedArrayCall
+{
+    public function nestedMap(array $data)
+    {
+        return array_map(strtolower(...), array: array_map(trim(...), $data));
+    }
+}
+
+?>
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/skip_already_callable.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/skip_already_callable.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector\Fixture;
+
+final class SkipAlreadyCallable
+{
+    public function skipFilter(array $data)
+    {
+        return array_filter($data, boolval(...));
+    }
+}
diff --git a/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/with_function_calls.php.inc b/rules-tests/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector/Fixture/with_function_calls.php.inc
diff --git a/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/nested_functions.php.inc b/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/nested_functions.php.inc
@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class NestedFunctions
+{
+    public function run()
+    {
+        $result = trim(strtolower(htmlspecialchars('  Hello World!  ')));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class NestedFunctions
+{
+    public function run()
+    {
+        $result = '  Hello World!  '
+            |> htmlspecialchars(...)
+            |> strtolower(...)
+            |> trim(...);
+    }
+}
+
+?>
diff --git a/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/return_nested.php.inc b/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/return_nested.php.inc
@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class ReturnNested
+{
+    public function run()
+    {
+        return trim(strtolower(htmlspecialchars('  Hello World!  ')));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class ReturnNested
+{
+    public function run()
+    {
+        return '  Hello World!  '
+            |> htmlspecialchars(...)
+            |> strtolower(...)
+            |> trim(...);
+    }
+}
+
+?>
diff --git a/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/skip_sole.php.inc b/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/skip_sole.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class SkipSole
+{
+    public function run()
+    {
+        $result = trim('  Hello World!  ');
+    }
+}
diff --git a/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/NestedFuncCallsToPipeOperatorRectorTest.php b/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/NestedFuncCallsToPipeOperatorRectorTest.php
@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class NestedFuncCallsToPipeOperatorRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}
diff --git a/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/config/configured_rule.php b/rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/config/configured_rule.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector;
+use Rector\ValueObject\PhpVersion;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(NestedFuncCallsToPipeOperatorRector::class);
+
+    $rectorConfig->phpVersion(PhpVersion::PHP_85);
+};
diff --git a/rules/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector.php b/rules/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector.php
