skip nullable property without null default, as null is always passed from outside to trigger

TomasVotruba · TomasVotruba · commit b91e37af46e4 · 2025-10-23T11:08:55.000+02:00
diff --git a/rules/Php81/Rector/ClassMethod/NewInInitializerRector.php b/rules/Php81/Rector/ClassMethod/NewInInitializerRector.php
@@ -81,11 +81,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->stmts === null || $node->stmts === []) {
-            return null;
-        }
-
-        if ($node->isAbstract() || $node->isAnonymous()) {
+        if ($this->shouldSkipClass($node)) {
             return null;
         }
 
@@ -104,6 +100,10 @@ public function refactor(Node $node): ?Node
             foreach ($params as $param) {
                 $paramName = $this->getName($param);
 
+                if ($param->type instanceof NullableType && $param->default === null) {
+                    continue;
+                }
+
                 $coalesce = $this->coalescePropertyAssignMatcher->matchCoalesceAssignsToLocalPropertyNamed(
                     $stmt,
                     $paramName
@@ -215,4 +215,13 @@ private function matchConstructorParams(ClassMethod $classMethod): array
 
         return $params;
     }
+
+    private function shouldSkipClass(Class_ $class): bool
+    {
+        if ($class->stmts === []) {
+            return true;
+        }
+
+        return $class->isAbstract() || $class->isAnonymous();
+    }
 }
