[typed] add mock object property type

TomasVotruba · TomasVotruba · commit c92e7c94f2a1 · 2022-08-06T13:46:29.000+02:00
diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php
@@ -6,9 +6,11 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
 use PHPStan\PhpDocParser\Ast\Type\TypeNode;
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\IntersectionType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use Rector\BetterPhpDocParser\ValueObject\Type\BracketsAwareIntersectionTypeNode;
 use Rector\Core\Exception\ShouldNotHappenException;
@@ -78,7 +80,7 @@ public function mapToPHPStanPhpDocTypeNode(Type $type, string $typeKind): TypeNo
     public function mapToPhpParserNode(Type $type, string $typeKind): ?Node
     {
         if (! $this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::INTERSECTION_TYPES)) {
-            return null;
+            return $this->matchMockObjectType($type);
         }
 
         $intersectionedTypeNodes = [];
@@ -93,7 +95,8 @@ public function mapToPhpParserNode(Type $type, string $typeKind): ?Node
                 $resolvedTypeName = (string) $resolvedType;
             }
 
-            if (in_array($resolvedTypeName, [self::STRING, 'object'], true)) {
+            if (in_array($resolvedTypeName, [self::STRING, '
+}object'], true)) {
                 return $resolvedType;
             }
 
@@ -102,4 +105,20 @@ public function mapToPhpParserNode(Type $type, string $typeKind): ?Node
 
         return new Node\IntersectionType($intersectionedTypeNodes);
     }
+
+    private function matchMockObjectType(IntersectionType $intersectionType): ?FullyQualified
+    {
+        // return mock object as the strict one
+        foreach ($intersectionType->getTypes() as $intersectionedType) {
+            if (! $intersectionedType instanceof ObjectType) {
+                continue;
+            }
+
+            if ($intersectionedType->getClassName() === 'PHPUnit\Framework\MockObject\MockObject') {
+                return new FullyQualified($intersectionedType->getClassName());
+            }
+        }
+
+        return null;
+    }
 }
diff --git a/rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromAssignsRector/Fixture/mock_property_type.php.inc b/rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromAssignsRector/Fixture/mock_property_type.php.inc
@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class MockPropertyType extends TestCase
+{
+    private $someValue;
+
+    protected function setUp(): void
+    {
+        $this->someValue = $this->createMock('SomeClass');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class MockPropertyType extends TestCase
+{
+    private \PHPUnit\Framework\MockObject\MockObject $someValue;
+
+    protected function setUp(): void
+    {
+        $this->someValue = $this->createMock('SomeClass');
+    }
+}
+
+?>
