first pass jupyter js test on CI:

etpinard · etpinard · commit 61f75d80fc19 · 2016-08-25T11:34:48.000-04:00
- add node.js to CI machine
- add PLOTLY_JUPYTER_TEST_DIR env variable
- make sure to `npm i` there
- add jupyter and ipykernel to optional requirements
- make sure to add kernel to jupyter list
- preprocess NB using that kernel
diff --git a/circle.yml b/circle.yml
@@ -7,6 +7,10 @@ machine:
     PLOTLY_PYTHON_VERSIONS: 2.7.8 3.3.3 3.4.1
     PLOTLY_CORE_REQUIREMENTS_FILE: ${PLOTLY_PACKAGE_ROOT}/requirements.txt
     PLOTLY_OPTIONAL_REQUIREMENTS_FILE: ${PLOTLY_PACKAGE_ROOT}/optional-requirements.txt
+    PLOTLY_JUPYTER_TEST_DIR: ${PLOTLY_PACKAGE_ROOT}/plotly/tests/test_core/test_jupyter
+
+  node:
+    version: 4.2.1
 
 dependencies:
 
@@ -22,6 +26,10 @@ dependencies:
     # we need to cd out of the project root to ensure the install worked
     - cd ~ && python -c "import plotly"
 
+    # install jupyter test JS requirements
+    - cd ${PLOTLY_JUPYTER_TEST_DIR} && npm i
+
+
   cache_directories:
 
     - "~/.pyenv/versions"  # attempt to just cache installed pyenv things
diff --git a/circle/setup.sh b/circle/setup.sh
@@ -39,4 +39,8 @@ for version in ${PLOTLY_PYTHON_VERSIONS[@]}; do
     pip install -r ${PLOTLY_OPTIONAL_REQUIREMENTS_FILE} ||
         error_exit "${SIG} ${LINENO}: can't install optional for Python ${version}."
 
+    # add python version to available jupyter kernel list
+    python -m ipykernel install --user --name ${version}
+    echo "${SIG} jupyter kernelspec list"
+    jupyter kernelspec list
 done
diff --git a/optional-requirements.txt b/optional-requirements.txt
@@ -24,3 +24,6 @@ pandas
 ## scipy deps for some FigureFactory functions ##
 scipy
 
+## jupyter ##
+jupyter
+ipykernel
diff --git a/plotly/tests/test_core/test_jupyter/test_jupyter.py b/plotly/tests/test_core/test_jupyter/test_jupyter.py
@@ -7,21 +7,26 @@
 from nbconvert.preprocessors import ExecutePreprocessor
 
 from unittest import TestCase
-from os import path
+from os import path, environ
 import subprocess
 
 PATH_ROOT = path.dirname(__file__)
 PATH_FIXTURES = path.join(PATH_ROOT, 'fixtures')
 PATH_TEST_NB = path.join(PATH_FIXTURES, 'test.ipynb')
 PATH_TEST_HTML = path.join(PATH_FIXTURES, 'test.html')
+PYENV_VERSION = environ['PYENV_VERSION']
 
 
 class PlotlyJupyterTestCase(TestCase):
     def setUp(self):
         with open(PATH_TEST_NB, 'r') as f:
             self.nb = nbformat.read(f, as_version=4)
 
-        self.ep = ExecutePreprocessor(timeout=600)
+        if PYENV_VERSION:
+            self.ep = ExecutePreprocessor(timeout=600, kernel_name=PYENV_VERSION)
+        else:
+            self.ep = ExecutePreprocessor(timeout=600)
+
         self.html_exporter = HTMLExporter()
 
         self.ep.preprocess(self.nb, {'metadata': {'path': '.'}})
