It appears that #3795 enabled the quick-repo-deletion button for all repositories - the PR title and linked issue reference enabling the feature for "empty" repositories, but it appears that the feature code actually defines empty as "has not been starred":
https://github.com/sindresorhus/refined-github/blob/eb79224b4dbf0852651c42cca2ff770ae185d100/source/features/quick-repo-deletion.tsx#L111-L119
This means that the delete button appears for all private repositories, especially organization repos, where users are unlikely to star an internal company repo. It would also appear for any personal repositories that haven't been starred, regardless of how many commits said repo has (like, you can have 100s of commits in a repo, and if nobody has starred it, this button still appears).
This doesn't seem like intended behavior. Having a very prominent Delete button for any repo that has no stars isn't quite the same as making it easy to clean up empty repositories.
Would it be possible to change the activation criteria? Perhaps it could take into account whether or not the repo actually contained commits (is it really empty, especially if it's not a fork), or whether it was a private repo. Or perhaps there's a better criteria all together for the intent of this feature. There's probably a narrower range of repos where having a featured delete button makes UX sense.
tl;dr - seeing a red DELETE button at the top of all our company repos is slightly concerning 😅
It appears that #3795 enabled the
quick-repo-deletionbutton for all repositories - the PR title and linked issue reference enabling the feature for "empty" repositories, but it appears that the feature code actually defines empty as "has not been starred":https://github.com/sindresorhus/refined-github/blob/eb79224b4dbf0852651c42cca2ff770ae185d100/source/features/quick-repo-deletion.tsx#L111-L119
This means that the delete button appears for all private repositories, especially organization repos, where users are unlikely to star an internal company repo. It would also appear for any personal repositories that haven't been starred, regardless of how many commits said repo has (like, you can have 100s of commits in a repo, and if nobody has starred it, this button still appears).
This doesn't seem like intended behavior. Having a very prominent
Deletebutton for any repo that has no stars isn't quite the same as making it easy to clean up empty repositories.Would it be possible to change the activation criteria? Perhaps it could take into account whether or not the repo actually contained commits (is it really empty, especially if it's not a fork), or whether it was a private repo. Or perhaps there's a better criteria all together for the intent of this feature. There's probably a narrower range of repos where having a featured delete button makes UX sense.
tl;dr - seeing a red
DELETEbutton at the top of all our company repos is slightly concerning 😅