Thanks to visit codestin.com
Credit goes to github.com

Skip to content

closing-remarks: incomplete documentation about ignored tags #8395

Description

@keysmashes

Description

This PR was merged and released, but RGH thinks otherwise:

Image

The merge commit definitely is actually released:

Image

Reading carefully the feature source code, I see that the tag (release_2024-04-13) is excluded because it doesn't contain a dotted version number (match of /\d[.]\d/). I think #7789 was intended to clarify this, but the wiki only mentions in passing that "Number-less tags" are excluded, and the tag definitely contains numbers.

Would you consider changing the phrasing from

Number-less tags and "nightly" tags are excluded.

to e.g.

Tags containing the word "nightly", or that don't look sufficiently like a version number, are excluded.

or extending the regex to e.g. /\d[.-]\d/, to permit tags with dashes between the numbers?

How to replicate the issue + URL

dregad/dokuwiki-plugin-cspheader#1

Extension version

25.4.8

Browser(s) used

Firefox 136.0.3

Token ⚠️

  • I set a token in the options page. I understand that some features require a token to work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions