POC restore linkification features #7668
Draft
+211
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR to track the work on:
Findings:
z-index
; The whole "file" lives in aposition: relative
. My previous:hover
demo no longer workstextarea
to a specific element under it: https://gist.github.com/kiliman/5d7a3826bc16f5967978336d026805a3Next steps for the POC
fullSourceText.slice(30, 35)
) because keywords may appear multiply times on the same linefullSourceText.replace(urlRegex, () => linkifier on indexes found)
)Wishlist
anchor
usage to provide hover state and/or a real link above the text area. This is a superior option to the click handler, but Firefox and Safari are left behind as usualTest URL
refined-github/test/linkify-urls-in-code.js
Line 42 in be756e6
Related