Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(testing): enable the development condition for the AppHarness - #6931

Merged
masenf merged 2 commits into
reflex-dev:mainfrom
benedikt-bartscher:fix-harness
Aug 24, 2026
Merged

fix(testing): enable the development condition for the AppHarness#6931
masenf merged 2 commits into
reflex-dev:mainfrom
benedikt-bartscher:fix-harness

Conversation

@benedikt-bartscher

@benedikt-bartscher benedikt-bartscher commented Aug 22, 2026 •
edited by cubic-dev-ai Bot
Loading

Copy link
Copy Markdown
Contributor

Review in cubic

@codspeed-hq

codspeed-hq Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 8 skipped benchmarks1

Comparing benedikt-bartscher:fix-harness (4e8a773) with main (d86f167)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@greptile-apps

greptile-apps Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes AppHarness launch its frontend with the development export condition, matching the existing frontend execution path and preventing React Router’s restart guard from failing on Bun-only installations.

  • Applies the development condition to both Node and Bun runtime options.
  • Preserves existing environment options while setting the harness port and color controls.
  • Adds focused unit coverage and a bug-fix news entry.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed
Filename Overview
reflex/testing.py Wraps the AppHarness frontend environment with the established development-condition helper while retaining existing subprocess settings.
tests/units/test_testing.py Verifies that AppHarness supplies the development condition through both NODE_OPTIONS and BUN_OPTIONS.
news/+harness-dev-condition.bugfix.md Documents the Bun-only frontend startup failure addressed by the change.

Reviews (2): Last reviewed commit: "thanks cubic" | Re-trigger Greptile

@benedikt-bartscher
benedikt-bartscher marked this pull request as ready for review August 22, 2026 13:30
@benedikt-bartscher
benedikt-bartscher requested a review from a team as a code owner August 22, 2026 13:30
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Aug 22, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/units/test_testing.py
@masenf
masenf merged commit d840662 into reflex-dev:main Aug 24, 2026
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
@masenf masenf masenf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benedikt-bartscher @masenf