Thanks to visit codestin.com
Credit goes to github.com

Skip to content

extra Compositions inside src/Video.jsx are confused and mislead #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lgh06 opened this issue Dec 28, 2021 · 3 comments
Open

extra Compositions inside src/Video.jsx are confused and mislead #6

lgh06 opened this issue Dec 28, 2021 · 3 comments

Comments

@lgh06
Copy link

lgh06 commented Dec 28, 2021 •
edited
Loading

template-helloworld-javascript/src/Video.jsx

Line 21 in a1a9655

<Composition

I think for a basic and minimal HelloWorld demo, line 21 to 36 are not nessesary in fact.
and these two extra Composition confused me a lot because there are <Logo> & <Title> & <Subtitle> inside Sequence again:

template-helloworld-javascript/src/HelloWorld.jsx

Line 28 in a1a9655

<Title titleText={titleText} titleColor={titleColor} />

@lgh06
Copy link
Author

lgh06 commented Dec 28, 2021 •
edited
Loading

image
finally I think I understand. a Sequence is not a must-need. Composition is a must-need.
however still confuse a newbie.

@lgh06
Copy link
Author

lgh06 commented Dec 29, 2021

remotion-dev/remotion#738

@tomByrer
Copy link

tomByrer commented Jan 4, 2022

I agree that the second & third <Composition> are not used.

But I would like to see extra <Composition> in the template that is actually used, so we can see how it is done & why/when it is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomByrer @lgh06