fix: remove internal setConfig method from in-memory client

tilyupo · tilyupo · commit 755e8a6ff98c · 2026-01-08T17:01:42.000+03:00
diff --git a/packages/sdk/src/in-memory.ts b/packages/sdk/src/in-memory.ts
@@ -102,7 +102,7 @@ function asHandle<T extends object>(
  * expect(client.get("feature-enabled")).toBe(false);
  *
  * // With overrides
- * client.setConfig("rate-limit", 100, {
+ * client.set("rate-limit", 100, {
  *   overrides: [{
  *     name: "premium-users",
  *     conditions: [{ operator: "equals", property: "plan", value: "premium" }],
@@ -157,22 +157,6 @@ export class InMemoryReplaneClient<T extends object = Record<string, unknown>> {
     return asHandle(this)._impl.getSnapshot();
   }
 
-  /**
-   * Set a config value (simple form without overrides).
-   *
-   * @param name - Config name
-   * @param value - Config value
-   *
-   * @example
-   * ```typescript
-   * client.set("feature-enabled", true);
-   * client.set("rate-limit", 500);
-   * ```
-   */
-  set<K extends keyof T>(name: K, value: T[K]): void {
-    asHandle(this)._impl.set(name, value);
-  }
-
   /**
    * Set a config with optional overrides.
    *
@@ -182,7 +166,7 @@ export class InMemoryReplaneClient<T extends object = Record<string, unknown>> {
    *
    * @example
    * ```typescript
-   * client.setConfig("rate-limit", 100, {
+   * client.set("rate-limit", 100, {
    *   overrides: [{
    *     name: "premium-users",
    *     conditions: [
@@ -193,8 +177,8 @@ export class InMemoryReplaneClient<T extends object = Record<string, unknown>> {
    * });
    * ```
    */
-  setConfig<K extends keyof T>(name: K, value: T[K], options?: SetConfigOptions): void {
-    asHandle(this)._impl.setConfig(name, value, options);
+  set<K extends keyof T>(name: K, value: T[K], options?: SetConfigOptions): void {
+    asHandle(this)._impl.set(name, value, options);
   }
 
   /**
@@ -327,11 +311,7 @@ class InMemoryReplaneClientImpl<T extends object = Record<string, unknown>> {
     };
   }
 
-  set<K extends keyof T>(name: K, value: T[K]): void {
-    this.setConfig(name, value);
-  }
-
-  setConfig<K extends keyof T>(name: K, value: T[K], options?: SetConfigOptions): void {
+  set<K extends keyof T>(name: K, value: T[K], options?: SetConfigOptions): void {
     const overrides: Override[] = options?.overrides ?? [];
 
     const config: ConfigDto = {
diff --git a/packages/sdk/tests/testing.spec.ts b/packages/sdk/tests/testing.spec.ts
@@ -61,10 +61,10 @@ describe("InMemoryReplaneClient", () => {
     });
   });
 
-  describe("setConfig with overrides", () => {
+  describe("set with overrides", () => {
     it("evaluates equals condition", () => {
       const client = new InMemoryReplaneClient<{ feature: boolean }>();
-      client.setConfig("feature", false, {
+      client.set("feature", false, {
         overrides: [
           {
             name: "beta-override",
@@ -81,7 +81,7 @@ describe("InMemoryReplaneClient", () => {
 
     it("evaluates in condition", () => {
       const client = new InMemoryReplaneClient<{ limit: number }>();
-      client.setConfig("limit", 100, {
+      client.set("limit", 100, {
         overrides: [
           {
             name: "premium-override",
@@ -101,7 +101,7 @@ describe("InMemoryReplaneClient", () => {
       const client = new InMemoryReplaneClient<{ feature: boolean }>({
         context: { env: "prod" },
       });
-      client.setConfig("feature", false, {
+      client.set("feature", false, {
         overrides: [
           {
             name: "prod-override",
@@ -118,7 +118,7 @@ describe("InMemoryReplaneClient", () => {
       const client = new InMemoryReplaneClient<{ feature: boolean }>({
         context: { env: "prod" },
       });
-      client.setConfig("feature", false, {
+      client.set("feature", false, {
         overrides: [
           {
             name: "beta-prod-override",
@@ -253,7 +253,7 @@ describe("InMemoryReplaneClient", () => {
 
     it("includes overrides in snapshot", () => {
       const client = new InMemoryReplaneClient<{ feature: boolean }>();
-      client.setConfig("feature", false, {
+      client.set("feature", false, {
         overrides: [
           {
             name: "beta",
