optparse TYPE_CHECKER signature is 'def check_mytype(option, opt, value)'

alexa-infra · alexa-infra · commit a1c3e0150642 · 2019-08-18T16:46:09.000+02:00
diff --git a/rethinkdb/utils_common.py b/rethinkdb/utils_common.py
@@ -153,15 +153,15 @@ def format_epilog(self, formatter):
     def __init__(self, *args, **kwargs):
         # -- Type Checkers
 
-        def check_tls_option(opt_str, value):
+        def check_tls_option(_, opt_str, value):
             value = str(value)
 
             if os.path.isfile(value):
                 return {'ca_certs': os.path.realpath(value)}
             else:
                 raise optparse.OptionValueError('Option %s value is not a file: %r' % (opt_str, value))
 
-        def check_db_table_option(value):
+        def check_db_table_option(_, opt_str, value):
             res = _tableNameRegex.match(value)
 
             if not res:
@@ -171,7 +171,7 @@ def check_db_table_option(value):
 
             return DbTable(res.group('db'), res.group('table'))
 
-        def check_positive_int(opt_str, value):
+        def check_positive_int(_, opt_str, value):
             if not isinstance(value, int) or value < 1:
                 raise optparse.OptionValueError('%s value must be an integer greater that 1: %s' % (opt_str, value))
 
@@ -183,7 +183,7 @@ def check_existing_file(_, opt_str, value):
 
             return os.path.realpath(value)
 
-        def check_new_file_location(opt_str, value):
+        def check_new_file_location(_, opt_str, value):
             try:
                 real_value = os.path.realpath(value)
             except Exception:
@@ -194,7 +194,7 @@ def check_new_file_location(opt_str, value):
 
             return real_value
 
-        def file_contents(opt_str, value):
+        def file_contents(_, opt_str, value):
             if not os.path.isfile(value):
                 raise optparse.OptionValueError('%s value is not an existing file: %r' % (opt_str, value))
 
