Closed
Description
Describe the bug
v2.4.3 tries to connect to localhost and ignores commandline arguments pointing to another host
v2.4.0 - v2.4.2.post1 error at check_tls_option()
v2.3.0.post6 last working version
To Reproduce
Steps to reproduce the behavior:
- run
rethinkdb-dump -c rethinkdb:28015 -f dump.tar.gz --tls-cert ./tls/rethinkdb-cert.pem --password-file pw
Expected behavior
A dump archive is successfully created without error
Errors
v2.4.3
$ rethinkdb-dump -c rethinkdb:28015 -f dump_2019-08-24.tar.gz --tls-cert ./tls/rethinkdb-cert.pem --password-file pw
Usage: rethinkdb dump [-c HOST:PORT] [-p] [--password-file FILENAME] [--tls-cert FILENAME] [-f FILE] [--clients NUM] [-e (DB | DB.TABLE)]...
rethinkdb-dump: error: Unable to connect to server: Could not connect to localhost:28015. Error: [Errno 99] Cannot assign requested address
v2.4.0 - v2.4.2.post1
$ rethinkdb-dump -c rethinkdb -f dump_2019-08-24.tar.gz --tls-cert ./tls/rethinkdb-cert.pem --password-file pw
Traceback (most recent call last):
File "/usr/local/bin/rethinkdb-dump", line 10, in <module>
sys.exit(main())
File "/usr/local/lib/python3.7/site-packages/rethinkdb/_dump.py", line 143, in main
options = parse_options(argv or sys.argv[2:], prog=prog)
File "/usr/local/lib/python3.7/site-packages/rethinkdb/_dump.py", line 94, in parse_options
options, args = parser.parse_args(argv)
File "/usr/local/lib/python3.7/site-packages/rethinkdb/utils_common.py", line 356, in parse_args
options, args = super(CommonOptionsParser, self).parse_args(*args, **kwargs)
File "/usr/local/lib/python3.7/optparse.py", line 1387, in parse_args
stop = self._process_args(largs, rargs, values)
File "/usr/local/lib/python3.7/optparse.py", line 1427, in _process_args
self._process_long_opt(rargs, values)
File "/usr/local/lib/python3.7/optparse.py", line 1501, in _process_long_opt
option.process(opt, value, values, self)
File "/usr/local/lib/python3.7/optparse.py", line 779, in process
value = self.convert_value(opt, value)
File "/usr/local/lib/python3.7/optparse.py", line 771, in convert_value
return self.check_value(opt, value)
File "/usr/local/lib/python3.7/optparse.py", line 766, in check_value
return checker(self, opt, value)
TypeError: check_tls_option() takes 2 positional arguments but 3 were given
System info
docker container built using FROM python:3
- OS:
$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
- Python version:
$ python -V
Python 3.7.4