Apply suggestions from code review

j-f1 · MaxDesiatov · web-flow · commit c74e3d1cdd8b · 2020-09-17T15:58:53.000-04:00
Co-authored-by: Max Desiatov &lt;max@desiatov.com&gt;
diff --git a/Sources/JavaScriptKit/BasicObjects/JSArray.swift b/Sources/JavaScriptKit/BasicObjects/JSArray.swift
@@ -36,8 +36,8 @@ extension JSArray: RandomAccessCollection {
     }
 
     public class Iterator: IteratorProtocol {
-        let jsObject: JSObject
-        var index = 0
+        private let jsObject: JSObject
+        private var index = 0
         init(jsObject: JSObject) {
             self.jsObject = jsObject
         }
diff --git a/Sources/JavaScriptKit/JSBridgedType.swift b/Sources/JavaScriptKit/JSBridgedType.swift
@@ -24,7 +24,7 @@ public protocol JSBridgedClass: JSBridgedType {
     static var constructor: JSFunction { get }
 
     /// The JavaScript object wrapped by this instance.
-    /// You may assume that `jsObject instanceof Self.constructor`
+    /// You may assume that `jsObject instanceof Self.constructor == true`
     var jsObject: JSObject { get }
 
     /// Create an instannce wrapping the given JavaScript object.
diff --git a/Sources/JavaScriptKit/JSValueConvertible.swift b/Sources/JavaScriptKit/JSValueConvertible.swift
@@ -266,6 +266,6 @@ extension Array where Element == JSValueConvertible {
 
 extension Array where Element: JSValueConvertible {
     func withRawJSValues<T>(_ body: ([RawJSValue]) -> T) -> T {
-        Array<JSValueConvertible>.withRawJSValues(self)(body)
+        [JSValueConvertible].withRawJSValues(self)(body)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,8 @@ extension JSArray: RandomAccessCollection {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public class Iterator: IteratorProtocol {`
`39`		`- let jsObject: JSObject`
`40`		`- var index = 0`
	`39`	`+ private let jsObject: JSObject`
	`40`	`+ private var index = 0`
`41`	`41`	`init(jsObject: JSObject) {`
`42`	`42`	`self.jsObject = jsObject`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,6 @@ extension Array where Element == JSValueConvertible {`
`266`	`266`
`267`	`267`	`extension Array where Element: JSValueConvertible {`
`268`	`268`	`func withRawJSValues<T>(_ body: ([RawJSValue]) -> T) -> T {`
`269`		`- Array<JSValueConvertible>.withRawJSValues(self)(body)`
	`269`	`+ [JSValueConvertible].withRawJSValues(self)(body)`
`270`	`270`	`}`
`271`	`271`	`}`