add support for benchmark.net json result files #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(also, many many kudos are in order here for the very nice development workflow you have, between the push hooks, action testing on commit, etc. 👍 ) |
now we're in line with the other languages
|
Ping... Would like to see this merged. |
|
For the record, I published this pull request to the Marketplace since this repository seems to be unmaintained given 3 months of inactivity. |
This was referenced Sep 4, 2020
|
thanks @Happypig375 !!! :) |
spl
pushed a commit
to terminusdb-labs/benchmark-tracker
that referenced
this pull request
Aug 5, 2021
|
Hello @ktrz! Are there any modifications to this PR that I can assist with to get it considered for a merge? Or would a rebase be enough? I guess I'd have to create a new PR if I don't have write access to baronfel's branch. |
|
resolved by #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close #33 if approved.
I've tried to follow the contributing guidelines while adding this, but of course it's hard to test the yaml all in one go.
Are there any other things I missed?