PR feedback: noOpacity; no need to add toSVG; no empty line after function line if it's the only empty line in the function body

monfera · monfera · commit af1c43b5f028 · 2017-05-09T08:53:47.000+02:00
diff --git a/src/traces/sankey/base_plot.js b/src/traces/sankey/base_plot.js
@@ -28,5 +28,3 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)
         oldFullLayout._paperdiv.selectAll('.sankey').remove();
     }
 };
-
-exports.toSVG = function() {};
diff --git a/src/traces/sankey/index.js b/src/traces/sankey/index.js
@@ -18,7 +18,7 @@ Plot.plot = require('./plot');
 Plot.moduleType = 'trace';
 Plot.name = 'sankey';
 Plot.basePlotModule = require('./base_plot');
-Plot.categories = [];
+Plot.categories = ['noOpacity'];
 Plot.meta = {
     description: [
         'Sankey plots for network flow data analysis.',
diff --git a/src/traces/sankey/plot.js b/src/traces/sankey/plot.js
@@ -47,7 +47,6 @@ function relatedNodes(l) {
 }
 
 function nodeHoveredStyle(sankeyNode, d, sankey) {
-
     if(d && sankey) {
         ownTrace(sankey, d)
             .selectAll('.sankeyLink')
@@ -57,7 +56,6 @@ function nodeHoveredStyle(sankeyNode, d, sankey) {
 }
 
 function nodeNonHoveredStyle(sankeyNode, d, sankey) {
-
     if(d && sankey) {
         ownTrace(sankey, d)
             .selectAll('.sankeyLink')
@@ -175,7 +173,6 @@ module.exports = function plot(gd, calcData) {
     var nodeHoverFollow = function(element, d) {
 
         var nodeRect = d3.select(element).select('.nodeRect');
-
         var boundingBox = nodeRect.node().getBoundingClientRect();
         var hoverCenterX0 = boundingBox.left - 2;
         var hoverCenterX1 = boundingBox.right + 2;

Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,3 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)`
`28`	`28`	`oldFullLayout._paperdiv.selectAll('.sankey').remove();`
`29`	`29`	`}`
`30`	`30`	`};`
`31`		`-`
`32`		`-exports.toSVG = function() {};`