Raise clear error when to field is supplied as a string

matthisk · matthisk · commit c5c49f5a8454 · 2015-12-09T10:27:15.000+01:00
diff --git a/stream/feed.py b/stream/feed.py
@@ -46,6 +46,9 @@ def add_activity(self, activity_data):
             activity_data = {'actor': 1, 'verb': 'tweet', 'object': 1}
             activity_id = feed.add_activity(activity_data)
         '''
+        if activity_data.get('to') and type(activity_data.get('to')) is str:
+            raise TypeError('please provide the activity\'s to field as a list not a string')
+
         if activity_data.get('to'):
             activity_data['to'] = self.add_to_signature(activity_data['to'])
 
diff --git a/stream/tests.py b/stream/tests.py
@@ -155,6 +155,17 @@ def test_add_activity_to(self):
         # and the flat feed
         activities = team_follower_feed.get(limit=1)['results']
         self.assertFirstActivityIDNotEqual(activities, activity_id)
+
+
+    def test_add_activity_to_type_error(self):
+        user_feed = getfeed('user', '1')
+        activity_data = {
+            'actor': 1, 'verb': 'tweet', 'object': 1,
+            'to': 'string'
+        }
+
+        with self.assertRaises(TypeError):
+            user_feed.add_activity(activity_data)
         
     def assertFirstActivityIDEqual(self, activities, correct_activity_id):
         activity_id = None
