columnwidth to accept strings

monfera · monfera · commit 725845ddd0e1 · 2017-11-27T15:42:01.000+01:00
diff --git a/src/traces/table/data_preparation_helper.js b/src/traces/table/data_preparation_helper.js
@@ -33,8 +33,8 @@ module.exports = function calc(gd, trace) {
     var columnOrder = trace._fullInput.columnorder;
     var columnWidths = headerValues.map(function(d, i) {
         return Array.isArray(trace.columnwidth) ?
-            trace.columnwidth[Math.min(i, trace.columnwidth.length - 1)] :
-            isFinite(trace.columnwidth) && trace.columnwidth !== null ? trace.columnwidth : 1;
+            Number(trace.columnwidth[Math.min(i, trace.columnwidth.length - 1)]) :
+            trace.columnwidth !== null && isFinite(Number(trace.columnwidth)) ? Number(trace.columnwidth) : 1;
     });
     var totalColumnWidths = columnWidths.reduce(function(p, n) {return p + n;}, 0);
 
diff --git a/test/jasmine/tests/table_test.js b/test/jasmine/tests/table_test.js
@@ -92,6 +92,20 @@ describe('table initialization tests', function() {
             expect(fullTrace.cells.values).toEqual([]);
         });
 
+        it('\'columnwidth\' specification should accept a numerical array', function() {
+            var fullTrace = _supply({
+                columnwidth: [1, 2, 3]
+            });
+            expect(fullTrace.columnwidth).toEqual([1, 2, 3]);
+        });
+
+        it('\'columnwidth\' specification should accept a string array (converted downstream)', function() {
+            var fullTrace = _supply({
+                columnwidth: ['1', '2', '3']
+            });
+            expect(fullTrace.columnwidth).toEqual(['1', '2', '3']);
+        });
+
         it('\'header\' should be used with default values where attributes are not provided', function() {
             var fullTrace = _supply({
                 header: {
