Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit b4ebef9

Browse files
authored
Rename base test assertion methods for consistency (open-telemetry#2084)
* Rename base test assertion methods for consistency * Renamed assertion method * Updated contrib SHA * Updated contrib SHA
1 parent 04f74ee commit b4ebef9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ env:
1010
# Otherwise, set variable to the commit of your branch on
1111
# opentelemetry-python-contrib which is compatible with these Core repo
1212
# changes.
13-
CONTRIB_REPO_SHA: 3ad534cbba41c2b92618f5f03c4c92cee4a72df6
13+
CONTRIB_REPO_SHA: 2a92e255f7595024242e45c0050c8f3de7140b6b
1414

1515
jobs:
1616
build:

tests/util/src/opentelemetry/test/test_base.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424

2525

2626
class TestBase(unittest.TestCase):
27+
# pylint: disable=C0103
28+
2729
@classmethod
2830
def setUpClass(cls):
2931
cls.original_tracer_provider = trace_api.get_tracer_provider()
@@ -44,11 +46,11 @@ def tearDownClass(cls):
4446
def setUp(self):
4547
self.memory_exporter.clear()
4648

47-
def check_span_instrumentation_info(self, span, module):
49+
def assertEqualSpanInstrumentationInfo(self, span, module):
4850
self.assertEqual(span.instrumentation_info.name, module.__name__)
4951
self.assertEqual(span.instrumentation_info.version, module.__version__)
5052

51-
def assert_span_has_attributes(self, span, attributes):
53+
def assertSpanHasAttributes(self, span, attributes):
5254
for key, val in attributes.items():
5355
self.assertIn(key, span.attributes)
5456
self.assertEqual(val, span.attributes[key])

0 commit comments

Comments
 (0)