Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Provide bottle(s) with rnp brew formulae #33

@maxirmx

Description

@maxirmx
          > @maxirmx can't we specify a bottle dependency on the particular botan version? The benefit of the bottle is to allow people not to go through compilation, and it is an important benefit.

My understanding is that botan provides a formula to install only the latest version. Thus, even if we specify a dependency on some other version of botan, it will not be installed.

I believe we can

  • make a formula that uses bottle if botan version matches and builds from source if botan version does not match
  • link botan as static library in homebrew formula. It will eliminate run-time dependency
  • link rnp agains more generic reference (botan-2.dylib instead of botan-2.19.dylib). This will probably work but it is something to be done in core rnp build scripts

Also I guess we will need several bottles to make it effective. Botan provides seven:

  • arm64_ventura
  • arm64_monterey
  • arm64_big_sur
  • ventura
  • monterey
  • big_sur
  • catalina

This may require cross-compile options that will also go to core rnp build scripts

I suggest we release a simple fix first since keeping the bottle does not look like a one-liner fix

Originally posted by @maxirmx in #32 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions