Thanks to visit codestin.com
Credit goes to github.com

Skip to content
/ http Public

Adding header value validation#26

Merged
msmakouz merged 4 commits into3.xfrom
bugfix/invalid-header
Apr 26, 2024
Merged

Adding header value validation#26
msmakouz merged 4 commits into3.xfrom
bugfix/invalid-header

Conversation

@msmakouz
Copy link
Member

@msmakouz msmakouz commented Apr 26, 2024 •
edited by coderabbitai bot
Loading

Q A
Bugfix? ✔️
Breaks BC? ❌
New feature? ❌
Issues roadrunner-php/issues#33

Summary by CodeRabbit

  • Refactor
    • Improved header value filtering to ensure only strings are processed in HTTP headers.

@coderabbitai
Copy link

coderabbitai bot commented Apr 26, 2024 •
edited
Loading

Walkthrough

The recent changes revolve around refining header management in HttpWorker by filtering for string values and improving testing in HttpWorkerTest with new methods and data providers. These updates aim to enhance the reliability and specificity of HTTP header processing and testing.

Changes

File Path Change Summary
src/.../HttpWorker.php Modified arrayToHeaderValue to filter and process string headers only.
tests/.../HttpWorkerTest.php Added testRespondWithProtoCodecWithHeaders and headersDataProvider to enhance header testing.

🐰✨
In the land of code where the data hops,
A little rabbit tweaked the ops.
Strings in headers, tests so fine,
Ensuring all the headers align.
Hop, hop, hop, on the digital vine! 🌿

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2cb4e6d and c4adb0c.
Files selected for processing (1)
  • src/HttpWorker.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/HttpWorker.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msmakouz msmakouz self-assigned this Apr 26, 2024
@msmakouz msmakouz added the bug Something isn't working label Apr 26, 2024
@msmakouz msmakouz added this to the 3.5.x milestone Apr 26, 2024
@msmakouz msmakouz requested review from roxblnfk and rustatian April 26, 2024 10:04
roxblnfk
roxblnfk approved these changes Apr 26, 2024
View reviewed changes
@msmakouz msmakouz merged commit 213cd0d into 3.x Apr 26, 2024
@msmakouz msmakouz deleted the bugfix/invalid-header branch April 26, 2024 11:16
roxblnfk
roxblnfk reviewed Apr 26, 2024
View reviewed changes
tests/Unit/HttpWorkerTest.php
['Content-Type' => 'application/x-www-form-urlencoded'],
['Content-Type' => new HeaderValue(['value' => ['application/x-www-form-urlencoded']])]
];
yield [['Content-Type' => new \stdClass()], []];
Copy link
Member

@roxblnfk roxblnfk Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't cover the change. It's better to use (object)['foo' => 'bar'] instead of stdClass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@rustatian rustatian rustatian approved these changes

Assignees

@msmakouz msmakouz

Labels

bug Something isn't working

Projects

None yet

Milestone

3.5.x

Development

Successfully merging this pull request may close these issues.

3 participants

@msmakouz @roxblnfk @rustatian