Avoid use of deprecated datetime.utcnow(). (apache#34572)

robertwb · web-flow · commit 698148e2c9ec · 2025-04-17T20:51:21.000-04:00
* Avoid use of deprecated datetime.utcnow().

* lint
diff --git a/sdks/python/apache_beam/examples/cookbook/bigtableio_it_test.py b/sdks/python/apache_beam/examples/cookbook/bigtableio_it_test.py
@@ -41,7 +41,6 @@
 try:
   from google.cloud._helpers import _datetime_from_microseconds
   from google.cloud._helpers import _microseconds_from_datetime
-  from google.cloud._helpers import UTC
   from google.cloud.bigtable import row, column_family, Client
 except ImportError:
   Client = None
@@ -54,7 +53,7 @@
 
 EXISTING_INSTANCES: list['google.cloud.bigtable.instance.Instance'] = []
 LABEL_KEY = 'python-bigtable-beam'
-label_stamp = datetime.datetime.utcnow().replace(tzinfo=UTC)
+label_stamp = datetime.datetime.now(datetime.timezone.utc)
 label_stamp_micros = _microseconds_from_datetime(label_stamp)
 LABELS = {LABEL_KEY: str(label_stamp_micros)}
 
@@ -156,7 +155,7 @@ def _delete_old_instances(self):
 
     def age_in_hours(micros):
       return (
-          datetime.datetime.utcnow().replace(tzinfo=UTC) -
+          datetime.datetime.now(datetime.timezone.utc) -
           (_datetime_from_microseconds(micros))).total_seconds() // 3600
 
     CLEAN_INSTANCE = [
diff --git a/sdks/python/apache_beam/examples/online_clustering.py b/sdks/python/apache_beam/examples/online_clustering.py
@@ -42,7 +42,8 @@ def __init__(self, checkpoints_path: str):
 
   def process(self, model):
     # generate ISO 8601
-    iso_timestamp = datetime.datetime.utcnow().strftime("%Y%m%dT%H%M%SZ")
+    iso_timestamp = datetime.datetime.now(
+        datetime.timezone.utc).strftime("%Y%m%dT%H%M%SZ")
     checkpoint_name = f'{self.checkpoints_path}/{iso_timestamp}.checkpoint'
     latest_checkpoint = f'{self.checkpoints_path}/latest.checkpoint'
     # rename previous checkpoint
diff --git a/sdks/python/apache_beam/io/gcp/bigtableio_it_test.py b/sdks/python/apache_beam/io/gcp/bigtableio_it_test.py
@@ -50,7 +50,7 @@
 
 
 def instance_prefix(instance):
-  datestr = "".join(filter(str.isdigit, str(datetime.utcnow().date())))
+  datestr = "".join(filter(str.isdigit, str(datetime.now(timezone.utc).date())))
   instance_id = '%s-%s-%s' % (instance, datestr, secrets.token_hex(4))
   assert len(instance_id) < 34, "instance id length needs to be within [6, 33]"
   return instance_id
diff --git a/sdks/python/apache_beam/metrics/cells.py b/sdks/python/apache_beam/metrics/cells.py
@@ -28,6 +28,7 @@
 import threading
 import time
 from datetime import datetime
+from datetime import timezone
 from typing import Iterable
 from typing import Optional
 from typing import Set
@@ -72,7 +73,7 @@ def get_cumulative(self):
 
   def to_runner_api_monitoring_info(self, name, transform_id):
     if not self._start_time:
-      self._start_time = datetime.utcnow()
+      self._start_time = datetime.now(timezone.utc)
     mi = self.to_runner_api_monitoring_info_impl(name, transform_id)
     mi.start_time.FromDatetime(self._start_time)
     return mi
diff --git a/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py b/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
@@ -46,6 +46,7 @@
 import warnings
 from copy import copy
 from datetime import datetime
+from datetime import timezone
 
 from apitools.base.py import encoding
 from apitools.base.py import exceptions
@@ -363,7 +364,7 @@ def _build_default_job_name(user_name):
     are removed. If necessary, the user_name is truncated to shorten
     the job name to 63 characters."""
     user_name = re.sub('[^-a-z0-9]', '', user_name.lower())
-    date_component = datetime.utcnow().strftime('%m%d%H%M%S-%f')
+    date_component = datetime.now(timezone.utc).strftime('%m%d%H%M%S-%f')
     app_user_name = 'beamapp-{}'.format(user_name)
     # append 8 random alphanumeric characters to avoid collisions.
     random_component = ''.join(
@@ -467,7 +468,7 @@ def __init__(self, options, proto_pipeline):
 
     # Client Request ID
     self.proto.clientRequestId = '{}-{}'.format(
-        datetime.utcnow().strftime('%Y%m%d%H%M%S%f'),
+        datetime.now(timezone.utc).strftime('%Y%m%d%H%M%S%f'),
         random.randrange(9000) + 1000)
 
     self.base64_str_re = re.compile(r'^[A-Za-z0-9+/]*=*$')
diff --git a/sdks/python/apache_beam/transforms/enrichment_handlers/bigtable_it_test.py b/sdks/python/apache_beam/transforms/enrichment_handlers/bigtable_it_test.py
@@ -136,17 +136,17 @@ def create_rows(table):
         column_family_id,
         product_id.encode(),
         str(item[product_id]),
-        timestamp=datetime.datetime.utcnow())
+        timestamp=datetime.datetime.now(datetime.timezone.utc))
     row.set_cell(
         column_family_id,
         product_name.encode(),
         item[product_name],
-        timestamp=datetime.datetime.utcnow())
+        timestamp=datetime.datetime.now(datetime.timezone.utc))
     row.set_cell(
         column_family_id,
         product_stock.encode(),
         str(item[product_stock]),
-        timestamp=datetime.datetime.utcnow())
+        timestamp=datetime.datetime.now(datetime.timezone.utc))
     row.commit()
 
 
