fixes and tests DotDict equality #4956

Snooz82 · Snooz82 · commit 74d1a5d03737 · 2023-11-27T16:01:58.000+01:00
Signed-off-by: René &lt;snooz@posteo.de&gt;
diff --git a/src/robot/utils/dotdict.py b/src/robot/utils/dotdict.py
@@ -60,6 +60,9 @@ def __delattr__(self, key):
     def __eq__(self, other):
         return dict.__eq__(self, other)
 
+    def __ne__(self, other):
+        return not self == other
+
     def __str__(self):
         return '{%s}' % ', '.join('%r: %r' % (key, self[key]) for key in self)
 
diff --git a/utest/utils/test_dotdict.py b/utest/utils/test_dotdict.py
@@ -2,7 +2,7 @@
 from collections import OrderedDict
 
 from robot.utils import DotDict
-from robot.utils.asserts import (assert_equal, assert_false, assert_not_equal,
+from robot.utils.asserts import (assert_equal, assert_false,
                                  assert_raises, assert_true)
 
 
@@ -34,7 +34,8 @@ def test_equality(self):
         assert_true(self.dd != DotDict())
 
     def test_equality_with_normal_dict(self):
-        assert_equal(self.dd, {'z': 1, 2: 'y', 'x': 3})
+        assert_true(self.dd == {'z': 1, 2: 'y', 'x': 3})
+        assert_false(self.dd != {'z': 1, 2: 'y', 'x': 3})
 
     def test_hash(self):
         assert_raises(TypeError, hash, self.dd)
@@ -79,12 +80,17 @@ def test_order_does_not_affect_equality(self):
         dd1 = DotDict(sorted(d.items()))
         dd2 = DotDict(reversed(list(dd1.items())))
         for d1, d2 in [(dd1, dd2), (dd1, d), (dd2, d), (dd1, od1), (dd2, od2)]:
-            assert_equal(d1, d2)
-            assert_equal(d2, d1)
+            assert_true(d1 == d2)
+            assert_false(d1 != d2)
+            assert_true(d2 == d1)
+            assert_false(d2 != d1)
         for d1, d2 in [(dd1, od2), (dd2, od1)]:
-            assert_equal(d1, d2)
-            assert_equal(d2, d1)
-        assert_not_equal(od1, od2)
+            assert_true(d1 == d2)
+            assert_false(d1 != d2)
+            assert_true(d2 == d1)
+            assert_false(d2 != d1)
+        assert_false(od1 == od2)
+        assert_true(od1 != od2)
 
 
 class TestNestedDotDict(unittest.TestCase):
