Efficiency

markettes · web-flow · commit f8605b957a7d · 2019-04-11T12:20:53.000+02:00
Just two small things that in case the number was very big could be helpful.
diff --git a/ciphers/Caesar.java b/ciphers/Caesar.java
@@ -24,8 +24,8 @@ public class Caesar {
     public static String encode(String message, int shift) {
         String encoded = "";
 
-        while (shift >= 26) { // 26 = number of latin letters
-            shift -= 26;
+        if (shift >= 26) { // 26 = number of latin letters
+            shift %= 26;
         }
 
         final int length = message.length();
@@ -62,8 +62,8 @@ public static String encode(String message, int shift) {
     public static String decode(String encryptedMessage, int shift) {
         String decoded = "";
 
-        while (shift >= 26) { // 26 = number of latin letters
-            shift -= 26;
+        if (shift >= 26) { // 26 = number of latin letters
+            shift %= 26;
         }
 
         final int length = encryptedMessage.length();
