fix(node): should call hooks with await (#950)

zscumt123 · web-flow · commit 1c5c7d594496 · 2024-04-23T04:58:27.000Z
diff --git a/packages/rolldown/src/plugin/bindingify-build-hooks.ts b/packages/rolldown/src/plugin/bindingify-build-hooks.ts
@@ -17,7 +17,7 @@ export function bindingifyBuildStart(
   const [handler, _optionsIgnoredSofar] = normalizeHook(hook)
 
   return async (ctx) => {
-    handler.call(ctx, options)
+    await handler.call(ctx, options)
   }
 }
 
@@ -30,7 +30,7 @@ export function bindingifyBuildEnd(
   const [handler, _optionsIgnoredSofar] = normalizeHook(hook)
 
   return async (err) => {
-    handler.call(null, err ? new Error(err) : undefined)
+    await handler.call(null, err ? new Error(err) : undefined)
   }
 }
 
@@ -144,6 +144,6 @@ export function bindingifyModuleParsed(
   const [handler, _optionsIgnoredSofar] = normalizeHook(hook)
 
   return async (ctx, moduleInfo) => {
-    handler.call(ctx, transformModuleInfo(moduleInfo))
+    await handler.call(ctx, transformModuleInfo(moduleInfo))
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export function bindingifyBuildStart(`
`17`	`17`	`const [handler, _optionsIgnoredSofar] = normalizeHook(hook)`
`18`	`18`
`19`	`19`	`return async (ctx) => {`
`20`		`- handler.call(ctx, options)`
	`20`	`+ await handler.call(ctx, options)`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`@@ -30,7 +30,7 @@ export function bindingifyBuildEnd(`
`30`	`30`	`const [handler, _optionsIgnoredSofar] = normalizeHook(hook)`
`31`	`31`
`32`	`32`	`return async (err) => {`
`33`		`- handler.call(null, err ? new Error(err) : undefined)`
	`33`	`+ await handler.call(null, err ? new Error(err) : undefined)`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`
`@@ -144,6 +144,6 @@ export function bindingifyModuleParsed(`
`144`	`144`	`const [handler, _optionsIgnoredSofar] = normalizeHook(hook)`
`145`	`145`
`146`	`146`	`return async (ctx, moduleInfo) => {`
`147`		`- handler.call(ctx, transformModuleInfo(moduleInfo))`
	`147`	`+ await handler.call(ctx, transformModuleInfo(moduleInfo))`
`148`	`148`	`}`
`149`	`149`	`}`