fix: chunk modules should include empty module (#1583)

underfin · web-flow · commit 4790d46f81c3 · 2024-07-11T07:30:29.000Z
&lt;!-- Thank you for contributing! --&gt;

### Description

&lt;!-- Please insert your description here and provide especially info
about the "what" this PR is solving --&gt;
diff --git a/crates/rolldown/src/utils/chunk/render_chunk.rs b/crates/rolldown/src/utils/chunk/render_chunk.rs
@@ -45,9 +45,12 @@ pub async fn render_chunk(
         .par_iter()
         .copied()
         .filter_map(|id| graph.module_table.modules[id].as_ecma())
-        .filter_map(|m| {
-          render_ecma_module(m, &graph.ast_table[m.idx], m.resource_id.as_ref(), options)
-            .map(|rendered| (m.idx, &m.resource_id, rendered))
+        .map(|m| {
+          (
+            m.idx,
+            &m.resource_id,
+            render_ecma_module(m, &graph.ast_table[m.idx], m.resource_id.as_ref(), options),
+          )
         })
         .collect::<Vec<_>>()
         .into_iter()
@@ -60,8 +63,7 @@ pub async fn render_chunk(
           if *id == graph.runtime.id() && matches!(options.format, OutputFormat::Cjs) =>
         {
           let maybe_runtime_module = rendered_iter.next();
-          if let Some((_, _module_resource_id, module_render_output)) = maybe_runtime_module {
-            let emitted_sources = module_render_output;
+          if let Some((_, _module_resource_id, Some(emitted_sources))) = maybe_runtime_module {
             for source in emitted_sources {
               concat_source.add_source(source);
             }
@@ -89,9 +91,10 @@ pub async fn render_chunk(
       }
 
       rendered_iter.for_each(|(_id, module_resource_id, module_render_output)| {
-        let emitted_sources = module_render_output;
-        for source in emitted_sources {
-          concat_source.add_source(source);
+        if let Some(emitted_sources) = module_render_output {
+          for source in emitted_sources {
+            concat_source.add_source(source);
+          }
         }
 
         // FIXME: NAPI-RS used CStr under the hood, so it can't handle null byte in the string.
diff --git a/packages/rolldown/src/binding.d.ts b/packages/rolldown/src/binding.d.ts
@@ -304,6 +304,8 @@ export declare function transform(filename: string, sourceText: string, options?
 
 export interface TransformOptions {
   sourceType?: 'script' | 'module' | 'unambiguous' | undefined
+  /** Force jsx parsing, */
+  jsx?: boolean
   typescript?: TypeScriptBindingOptions
   react?: ReactBindingOptions
   es2015?: Es2015BindingOptions
diff --git a/packages/rolldown/tests/fixtures/plugin/write-bundle/_config.ts b/packages/rolldown/tests/fixtures/plugin/write-bundle/_config.ts
@@ -4,12 +4,14 @@ import type { RolldownOutputChunk } from '../../../../src'
 import { defineTest } from '@tests'
 
 const entry = path.join(__dirname, './main.js')
+const foo = path.join(__dirname, './foo.js')
 
 const writeBundleFn = vi.fn()
 
 export default defineTest({
   config: {
     input: entry,
+    treeshake: false,
     plugins: [
       {
         name: 'test-plugin',
@@ -25,8 +27,9 @@ export default defineTest({
           expect(chunk.facadeModuleId).toBe(entry)
           expect(chunk.exports.length).toBe(0)
           expect(chunk.imports).length(0)
-          expect(chunk.moduleIds).toStrictEqual([entry])
-          expect(Object.keys(chunk.modules).length).toBe(1)
+          // The `foo.js` should be include `modules/moduleIds` even it is empty.
+          expect(chunk.moduleIds).toStrictEqual([foo, entry])
+          expect(Object.keys(chunk.modules).length).toStrictEqual(2)
         },
       },
     ],
diff --git a/packages/rolldown/tests/fixtures/plugin/write-bundle/foo.js b/packages/rolldown/tests/fixtures/plugin/write-bundle/foo.js
diff --git a/packages/rolldown/tests/fixtures/plugin/write-bundle/main.js b/packages/rolldown/tests/fixtures/plugin/write-bundle/main.js
@@ -1 +1,2 @@
+import './foo'
 console.log()
