feat: support flags for hybrid regex (#1915)

shulaoda · IWANABETHATGUY · web-flow · commit 5ad5820c60f5 · 2024-08-09T11:37:33.000Z
### Description closes #1911  --------- Co-authored-by: IWANABETHATGUY <974153916@qq.com>
diff --git a/crates/rolldown_common/src/types/js_regex.rs b/crates/rolldown_common/src/types/js_regex.rs
@@ -8,10 +8,21 @@ pub enum HybridRegex {
 }
 
 impl HybridRegex {
-  pub fn new(source: &str) -> anyhow::Result<Self> {
-    match regex::Regex::new(source).map(HybridRegex::Optimize) {
+  pub fn new(pattern: &str) -> anyhow::Result<Self> {
+    match regex::Regex::new(pattern).map(HybridRegex::Optimize) {
       Ok(reg) => Ok(reg),
-      Err(_) => regress::Regex::new(source).map(HybridRegex::Ecma).map_err(anyhow::Error::from),
+      Err(_) => regress::Regex::new(pattern).map(HybridRegex::Ecma).map_err(anyhow::Error::from),
+    }
+  }
+
+  pub fn with_flags(pattern: &str, flags: &str) -> anyhow::Result<Self> {
+    let regex_pattern = if flags.is_empty() { pattern } else { &format!("(?{flags}){pattern}") };
+
+    match regex::Regex::new(regex_pattern).map(HybridRegex::Optimize) {
+      Ok(reg) => Ok(reg),
+      Err(_) => regress::Regex::with_flags(pattern, flags)
+        .map(HybridRegex::Ecma)
+        .map_err(anyhow::Error::from),
     }
   }
 
@@ -22,3 +33,14 @@ impl HybridRegex {
     }
   }
 }
+
+mod test {
+  #[test]
+  fn with_flags() {
+    let reg = super::HybridRegex::with_flags("a", "i").unwrap();
+    assert!(reg.matches("A"));
+
+    let reg = super::HybridRegex::new("a").unwrap();
+    assert!(!reg.matches("A"));
+  }
+}
