fix: avoid loop at call TransformPluginContext#error (#2332)

underfin · web-flow · commit 7c699da1a824 · 2024-09-26T07:44:51.000Z
### Description close #2326
diff --git a/packages/rolldown/src/plugin/transform-plugin-context.ts b/packages/rolldown/src/plugin/transform-plugin-context.ts
@@ -5,7 +5,7 @@ import type {
 import type { LoggingFunctionWithPosition, RollupError } from '../rollup'
 import { normalizeLog } from '../log/logHandler'
 import { PluginContext } from './plugin-context'
-import { augmentCodeLocation } from '../log/logs'
+import { augmentCodeLocation, error, logPluginError } from '../log/logs'
 import { PluginContextData } from './plugin-context-data'
 import { NormalizedInputOptions } from '..'
 import type { Plugin } from './index'
@@ -41,14 +41,14 @@ export class TransformPluginContext extends PluginContext {
     this.warn = getLogHandler(this.warn)
     this.info = getLogHandler(this.info)
     this.error = (
-      error: RollupError | string,
+      e: RollupError | string,
       pos?: number | { column: number; line: number },
     ): never => {
-      if (typeof error === 'string') error = { message: error }
-      if (pos) augmentCodeLocation(error, pos, moduleSource, moduleId)
-      error.id = moduleId
-      error.hook = 'transform'
-      return this.error(error)
+      if (typeof e === 'string') e = { message: e }
+      if (pos) augmentCodeLocation(e, pos, moduleSource, moduleId)
+      e.id = moduleId
+      e.hook = 'transform'
+      return error(logPluginError(normalizeLog(e), plugin.name || 'unknown'))
     }
     // this.getCombinedSourcemap = () => JSON.parse(inner.getCombinedSourcemap())
   }
diff --git a/packages/rolldown/tests/plugin/plugin.test.ts b/packages/rolldown/tests/plugin/plugin.test.ts
@@ -105,3 +105,24 @@ describe('Plugin closeBundle hook', async () => {
     }
   })
 })
+
+test('call transformContext error', async () => {
+  try {
+    const build = await rolldown({
+      input: './main.js',
+      cwd: import.meta.dirname,
+      plugins: [
+        {
+          transform() {
+            this.error('transform hook error')
+          },
+        },
+      ],
+    })
+    await build.write({})
+  } catch (error: any) {
+    expect(error.message).toMatchInlineSnapshot(
+      `"Rolldown internal error: GenericFailure, RollupError: transform hook error"`,
+    )
+  }
+})
