Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d16be62

Browse files
IWANABETHATGUYIWANABETHATGUY
authored
fix: diff custom resolver (#2463)
<!-- Thank you for contributing! --> ### Description 1. esbuild test cases don't not have a unify pattern to do output file remapping, so we need a way to customize mapping logic, this pr adds a custom resolver. <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
1 parent 3008d46 commit d16be62

20 files changed

Lines changed: 180 additions & 239 deletions

File tree

crates/rolldown/tests/esbuild/default/entry_names_chunk_names_ext_placeholder/diff.md renamed to crates/rolldown/tests/esbuild/default/entry_names_chunk_names_ext_placeholder/bypass.md

Lines changed: 28 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Reason
2-
1. custom diff resolver
2+
1. css comments
3+
2. different chunk file naming style
34
# Diff
45
## /out/main/js/entry1-4X3SO762.js
56
### esbuild
@@ -11,16 +12,22 @@ console.log("entry1");
1112
```
1213
### rolldown
1314
```js
15+
import "./shared.js";
1416

17+
//#region entries/entry1.js
18+
console.log("entry1");
19+
20+
//#endregion
1521
```
1622
### diff
1723
```diff
1824
===================================================================
1925
--- esbuild /out/main/js/entry1-4X3SO762.js
20-
+++ rolldown
21-
@@ -1,2 +0,0 @@
26+
+++ rolldown entries_entry1.js
27+
@@ -1,2 +1,2 @@
2228
-import "../../common/js/chunk-XHGYOYUR.js";
23-
-console.log("entry1");
29+
+import "./shared.js";
30+
console.log("entry1");
2431

2532
```
2633
## /out/main/js/entry2-URQRHZS5.js
@@ -33,35 +40,22 @@ console.log("entry2");
3340
```
3441
### rolldown
3542
```js
43+
import "./shared.js";
44+
45+
//#region entries/entry2.js
46+
console.log("entry2");
3647

48+
//#endregion
3749
```
3850
### diff
3951
```diff
4052
===================================================================
4153
--- esbuild /out/main/js/entry2-URQRHZS5.js
42-
+++ rolldown
43-
@@ -1,2 +0,0 @@
54+
+++ rolldown entries_entry2.js
55+
@@ -1,2 +1,2 @@
4456
-import "../../common/js/chunk-XHGYOYUR.js";
45-
-console.log("entry2");
46-
47-
```
48-
## /out/common/js/chunk-XHGYOYUR.js
49-
### esbuild
50-
```js
51-
// src/lib/shared.js
52-
console.log("shared");
53-
```
54-
### rolldown
55-
```js
56-
57-
```
58-
### diff
59-
```diff
60-
===================================================================
61-
--- esbuild /out/common/js/chunk-XHGYOYUR.js
62-
+++ rolldown
63-
@@ -1,1 +0,0 @@
64-
-console.log("shared");
57+
+import "./shared.js";
58+
console.log("entry2");
6559

6660
```
6761
## /out/main/css/entry1-3JZGIUSL.css
@@ -74,19 +68,21 @@ a:after {
7468
```
7569
### rolldown
7670
```js
71+
a:after { content: "entry1" }
7772

7873
```
7974
### diff
8075
```diff
8176
===================================================================
8277
--- esbuild /out/main/css/entry1-3JZGIUSL.css
83-
+++ rolldown
84-
@@ -1,4 +0,0 @@
78+
+++ rolldown entries_entry1.css
79+
@@ -1,4 +1,1 @@
8580
-/* src/entries/entry1.css */
8681
-a:after {
8782
- content: "entry1";
8883
-}
8984
\ No newline at end of file
85+
+a:after { content: "entry1" }
9086

9187
```
9288
## /out/main/css/entry2-NXZBPPIA.css
@@ -99,18 +95,20 @@ a:after {
9995
```
10096
### rolldown
10197
```js
98+
a:after { content: "entry2" }
10299

103100
```
104101
### diff
105102
```diff
106103
===================================================================
107104
--- esbuild /out/main/css/entry2-NXZBPPIA.css
108-
+++ rolldown
109-
@@ -1,4 +0,0 @@
105+
+++ rolldown entries_entry2.css
106+
@@ -1,4 +1,1 @@
110107
-/* src/entries/entry2.css */
111108
-a:after {
112109
- content: "entry2";
113110
-}
114111
\ No newline at end of file
112+
+a:after { content: "entry2" }
115113

116114
```

‎crates/rolldown/tests/esbuild/default/entry_names_chunk_names_ext_placeholder/diff.config.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
module.exports = {
2+
resolver: {
3+
"/out/main/js/entry1-4X3SO762.js": "entries_entry1.js",
4+
"/out/main/js/entry2-URQRHZS5.js": "entries_entry2.js",
5+
"/out/common/js/chunk-XHGYOYUR.js": "shared.js",
6+
"/out/main/css/entry1-3JZGIUSL.css": "entries_entry1.css",
7+
"/out/main/css/entry2-NXZBPPIA.css": "entries_entry2.css"
8+
}
9+
}

‎crates/rolldown/tests/esbuild/default/outbase/diff.config.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
module.exports = {
2+
resolver: {
3+
"/out/a/b/c.js": "c.js",
4+
"/out/a/b/d.js": "d.js",
5+
},
6+
};

‎crates/rolldown/tests/esbuild/default/outbase/diff.md‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

‎crates/rolldown/tests/esbuild/default/output_extension_remapping_dir/diff.config.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
resolver: {
3+
"/out/entry.notjs": "entry.js",
4+
},
5+
};

‎crates/rolldown/tests/esbuild/default/output_extension_remapping_dir/diff.md‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎crates/rolldown/tests/esbuild/default/require_with_template/diff.config.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
resolver: {
3+
"/out.js": "a.js",
4+
},
5+
};

‎crates/rolldown/tests/esbuild/default/require_with_template/diff.md‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎crates/rolldown/tests/esbuild/default/scoped_external_module_exclusion/diff.config.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
resolver: {
3+
"/out.js": "index.js"
4+
},
5+
};

‎crates/rolldown/tests/esbuild/default/scoped_external_module_exclusion/diff.md‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

0 commit comments

Comments
 (0)