Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(node/plugin): support PluginContext#resolve#1102

Merged
hyf0 merged 1 commit into
mainfrom
05-13-feat_node_plugin_support_plugincontext_resolve_
May 12, 2024
Merged

feat(node/plugin): support PluginContext#resolve#1102
hyf0 merged 1 commit into
mainfrom
05-13-feat_node_plugin_support_plugincontext_resolve_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented May 12, 2024 •
edited
Loading

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented May 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 690883d
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6640f0f8d579420008ff2a89

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 86.73%. Comparing base (49a134a) to head (690883d).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/rolldown_plugin/src/plugin_context.rs 0.00% 17 Missing ⚠️
crates/rolldown_plugin/src/plugin_driver/mod.rs 27.27% 8 Missing ⚠️
crates/rolldown_utils/src/path_buf_ext.rs 0.00% 5 Missing ⚠️
crates/rolldown_utils/src/path_ext.rs 0.00% 5 Missing ⚠️
...s/rolldown_plugin/src/plugin_driver/build_hooks.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
- Coverage   87.16%   86.73%   -0.44%     
==========================================
  Files         118      120       +2     
  Lines        5908     5941      +33     
==========================================
+ Hits         5150     5153       +3     
- Misses        758      788      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2024

Benchmarks Rust

  • target: main(c68836a)
  • pr: 05-13-feat_node_plugin_support_plugincontext_resolve_(690883d)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     28.9±0.15ms        ? ?/sec    1.00     29.0±0.26ms        ? ?/sec
rolldown benchmark/threejs-scan            1.02     20.4±0.84ms        ? ?/sec    1.00     20.1±0.07ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     40.0±0.88ms        ? ?/sec    1.01     40.3±0.66ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.01    315.5±9.45ms        ? ?/sec    1.00    311.2±1.50ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    205.7±1.45ms        ? ?/sec    1.01    207.1±3.07ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    429.7±6.30ms        ? ?/sec    1.00   431.7±11.16ms        ? ?/sec

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2024

CodSpeed Performance Report

Merging #1102 will not alter performance

Comparing 05-13-feat_node_plugin_support_plugincontext_resolve_ (690883d) with main (0e60949)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 merged commit 5bcf3ed into main May 12, 2024
@hyf0 hyf0 deleted the 05-13-feat_node_plugin_support_plugincontext_resolve_ branch May 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0