You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@AliceLanniste Hi, I would like to further discuss this function.
In your version, process.env.NODE_ENV will be expanded to typeof process, typeof env, but I think in actual use, the more common usage is as follows:
This will cause typeof process.env === "object" not to be replaced and console.log('production'); won't be executed, which can also be seen in the snapshot of this pr.
Secondly, taking your replacement result typeof process!== as an example, after constructing the replacement regular expression, the default delimiter will be added on both sides of this replacement: \btypeof process!==\b(?!\.). In the above usage, this will not match because the equal sign is not followed by a word boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue:#2057 . fix the function of
expand_typeof_replacements