Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(rust): add ModuleType::Css#2247

Merged
IWANABETHATGUY merged 1 commit into
mainfrom
09-17-feat_rust_add_moduletype_css_
Sep 17, 2024
Merged

feat(rust): add ModuleType::Css#2247
IWANABETHATGUY merged 1 commit into
mainfrom
09-17-feat_rust_add_moduletype_css_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 17, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 227ab29
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66e96a8013b35d00082ba05e

@hyf0 hyf0 marked this pull request as ready for review September 17, 2024 08:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 17, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(dab103f)
  • pr: 09-17-feat_rust_add_moduletype_css_(227ab29)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     55.4±2.71ms        ? ?/sec    1.13     62.5±1.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     75.5±1.01ms        ? ?/sec    1.12     84.2±2.46ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.1±0.94ms        ? ?/sec    1.09    101.1±1.67ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     62.0±1.15ms        ? ?/sec    1.10     68.1±0.90ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    103.8±1.25ms        ? ?/sec    1.04    108.4±1.43ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    181.2±5.35ms        ? ?/sec    1.18    213.7±7.15ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    225.7±7.42ms        ? ?/sec    1.17    263.2±7.32ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    118.0±1.87ms        ? ?/sec    1.05    123.9±1.91ms        ? ?/sec
bundle/bundle@threejs                                               1.00     35.7±2.38ms        ? ?/sec    1.01     36.0±0.73ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     76.8±2.64ms        ? ?/sec    1.09     83.6±1.63ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     95.5±1.86ms        ? ?/sec    1.08    103.1±0.81ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     43.7±0.49ms        ? ?/sec    1.05     45.7±0.36ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    357.3±2.71ms        ? ?/sec    1.05    374.5±3.35ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01   991.0±15.30ms        ? ?/sec    1.00   985.6±10.89ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1280.2±22.13ms        ? ?/sec    1.01  1298.8±13.16ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    427.4±2.76ms        ? ?/sec    1.02    437.3±2.89ms        ? ?/sec
remapping/remapping                                                 1.01     33.4±0.38ms        ? ?/sec    1.00     33.0±0.18ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     84.1±0.60ms        ? ?/sec    1.02     85.8±0.47ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.3±1.08ms        ? ?/sec    1.01     82.4±1.02ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.3±1.05ms        ? ?/sec    1.01     25.6±0.34ms        ? ?/sec
scan/scan@threejs10x                                                1.00    253.2±2.30ms        ? ?/sec    1.03    260.3±3.01ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request Sep 17, 2024
Merged
@hyf0 hyf0 force-pushed the 09-17-feat_rust_add_moduletype_css_ branch from 613a468 to 227ab29 Compare September 17, 2024 11:39
@hyf0 hyf0 mentioned this pull request Sep 17, 2024
Merged
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 7531196 Sep 17, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the 09-17-feat_rust_add_moduletype_css_ branch September 17, 2024 13:02
This was referenced Sep 17, 2024
Merged
Merged
This was referenced Oct 18, 2024
Closed
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Oct 18, 2024
@burhanuday
feat: add css module type to output options (#2464)
c19f7b8 
<!-- Thank you for contributing! -->

### Description

#2247 Added CSS module type
support
This PR adds it to the schema

Related to #2329

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY