Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(plugin): ensure correct execution order#2602

Merged
hyf0 merged 2 commits into
mainfrom
js-sider-plugin-order
Nov 5, 2024
Merged

fix(plugin): ensure correct execution order#2602
hyf0 merged 2 commits into
mainfrom
js-sider-plugin-order

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Nov 5, 2024

Description

  • support js side hooks plugin order
  • disable buildStart hook run in parallel, it break plugin order behavior. We could make the plugin run in parallel for supported hooks at future.
  • refactor plugin order test follow rollup test

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 66219d4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6729e0dbe190f2000859aa79

@underfin underfin enabled auto-merge November 5, 2024 09:10
hyf0
hyf0 reviewed Nov 5, 2024
View reviewed changes
Comment thread crates/rolldown_plugin/src/plugin_driver/build_hooks.rs
hyf0
hyf0 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it to ensure the correct behavior first.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.10     67.0±1.77ms        ? ?/sec    1.00     61.1±1.15ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.04     91.1±2.34ms        ? ?/sec    1.00     87.5±2.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03    104.4±3.46ms        ? ?/sec    1.00    101.6±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     71.3±1.66ms        ? ?/sec    1.01     72.2±1.65ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    113.6±1.52ms        ? ?/sec    1.00    112.3±2.45ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.16   249.3±17.57ms        ? ?/sec    1.00    214.8±7.69ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.04   287.0±15.18ms        ? ?/sec    1.00   277.2±15.25ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    128.1±1.95ms        ? ?/sec    1.00    127.1±3.26ms        ? ?/sec
bundle/bundle@threejs                                               1.00     39.3±1.14ms        ? ?/sec    1.03     40.4±4.16ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02    102.0±2.62ms        ? ?/sec    1.00    100.2±3.20ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    116.3±4.31ms        ? ?/sec    1.00    116.4±2.66ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.7±1.06ms        ? ?/sec    1.02     47.7±0.77ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    398.1±6.14ms        ? ?/sec    1.00    395.6±8.35ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1288.2±21.74ms        ? ?/sec    1.01  1299.9±18.38ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1540.6±15.14ms        ? ?/sec    1.00  1529.1±23.52ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    459.6±7.60ms        ? ?/sec    1.00    458.7±5.82ms        ? ?/sec
remapping/remapping                                                 1.03     29.5±0.30ms        ? ?/sec    1.00     28.6±0.24ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     69.3±0.42ms        ? ?/sec    1.02     70.7±0.44ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     89.2±3.38ms        ? ?/sec    1.01     90.5±2.20ms        ? ?/sec
scan/scan@threejs                                                   1.02     28.3±0.77ms        ? ?/sec    1.00     27.9±0.56ms        ? ?/sec
scan/scan@threejs10x                                                1.02    288.7±5.78ms        ? ?/sec    1.00    284.0±3.73ms        ? ?/sec

@hyf0 hyf0 disabled auto-merge November 5, 2024 09:35
@hyf0 hyf0 changed the title fix: cleanup plugin order fix(plugin): ensure correct execution order Nov 5, 2024
@hyf0 hyf0 enabled auto-merge November 5, 2024 09:36
@hyf0 hyf0 added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 26a4031 Nov 5, 2024
@hyf0 hyf0 deleted the js-sider-plugin-order branch November 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0