feat: empty module should have ExportsKind::None#317
Merged
Conversation
Member
Author
0cb68ca to
eae1e57
Compare
hyf0
commented
Nov 17, 2023
| ## entry_js.mjs | ||
|
|
||
| ```js | ||
| import { __commonJS, __toESM } from "./_rolldown_runtime.mjs"; |
Member
Author
There was a problem hiding this comment.
I wasn't expected to fix unnecessary import of _toESM problem in this PR :).
b73da4f to
1e61efd
Compare
Base automatically changed from
11-17-chore_tweak_visitability_of_Scanner_
to
main
November 18, 2023 03:30
eae1e57 to
dd8e8b6
Compare
This was referenced Nov 18, 2023
underfin
approved these changes
Nov 19, 2023
This was referenced Nov 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan