Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: dynamic import chunk is_entry should be false#361

Merged
underfin merged 1 commit into
mainfrom
11-22-fix_dynamic_import_chunk_is_entry_should_be_false
Nov 22, 2023
Merged

fix: dynamic import chunk is_entry should be false#361
underfin merged 1 commit into
mainfrom
11-22-fix_dynamic_import_chunk_is_entry_should_be_false

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Nov 22, 2023

Description

Test Plan

@underfin underfin mentioned this pull request Nov 22, 2023
Merged
@underfin
Copy link
Copy Markdown
Contributor Author

underfin commented Nov 22, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 22, 2023
Closed
Merged
hyf0
hyf0 reviewed Nov 22, 2023
View reviewed changes
Comment thread crates/rolldown/tests/common/case.rs Outdated
}
}

fn render_stats_to_snapshot(&mut self, assets: Vec<Output>) {
Copy link
Copy Markdown
Member

@hyf0 hyf0 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. It would be good if you could separate the testing changes in another PR.

I'm not sure if we need this information. I tend to not add this.

Copy link
Copy Markdown
Contributor Author

@underfin underfin Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure the output stats are tested, Add this to the rust side because it is easy to debugger than js side. Maybe you have another idea for this?

Copy link
Copy Markdown
Contributor Author

@underfin underfin Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need this information. I tend to not add this.

The information is used at vite, it is also rust exported stats data, it should be tested.

Copy link
Copy Markdown
Member

@hyf0 hyf0 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on how rollup or esbuild test this?

Copy link
Copy Markdown
Contributor Author

@underfin underfin Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see here https://github.com/rollup/rollup/blob/master/test/hooks/index.js#L915

Copy link
Copy Markdown
Contributor Author

@underfin underfin Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the test at the pr, it is can merged at now

Base automatically changed from 11-22-refactor_add_EntryPoint_ to main November 22, 2023 12:28
@underfin underfin force-pushed the 11-22-fix_dynamic_import_chunk_is_entry_should_be_false branch from f051c35 to 239cf2e Compare November 22, 2023 12:39
@underfin underfin force-pushed the 11-22-fix_dynamic_import_chunk_is_entry_should_be_false branch from 239cf2e to 325c04c Compare November 22, 2023 12:42
@underfin underfin merged commit 6f2b75a into main Nov 22, 2023
@underfin underfin deleted the 11-22-fix_dynamic_import_chunk_is_entry_should_be_false branch November 22, 2023 12:50
@hyf0 hyf0 mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0