Thanks to visit codestin.com
Credit goes to github.com

Skip to content

revert: Revert "refactor: implement ConcatSource"#612

Merged
hyf0 merged 1 commit into
mainfrom
revert-611-refactor_concat_sourcemap
Mar 19, 2024
Merged

revert: Revert "refactor: implement ConcatSource"#612
hyf0 merged 1 commit into
mainfrom
revert-611-refactor_concat_sourcemap

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Mar 19, 2024

Reverts #611.

It breaks benchmark action.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 19, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b492e99
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65f94253a917ec00085c97f5

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 41.66667% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 78.53%. Comparing base (a05eb3d) to head (b492e99).

Files Patch % Lines
crates/rolldown_sourcemap/src/concat_sourcemap.rs 0.00% 18 Missing ⚠️
crates/rolldown/src/chunk/mod.rs 83.33% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   78.63%   78.53%   -0.11%     
==========================================
  Files         142      142              
  Lines        6599     6572      -27     
==========================================
- Hits         5189     5161      -28     
- Misses       1410     1411       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit dc32a76 into main Mar 19, 2024
@hyf0 hyf0 deleted the revert-611-refactor_concat_sourcemap branch March 19, 2024 07:46
hyf0 added a commit that referenced this pull request Mar 19, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 19, 2024

CodSpeed Performance Report

Merging #612 will not alter performance

⚠️ No base runs were found

Falling back to comparing revert-611-refactor_concat_sourcemap (b492e99) with main (f2dcda2)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants